From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26951 invoked by alias); 17 Feb 2016 16:07:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26940 invoked by uid 89); 17 Feb 2016 16:07:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=ct, Hx-languages-length:1444, heads-up, headsup X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 17 Feb 2016 16:07:29 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW4dO-0003Ew-8H for gdb-patches@sourceware.org; Wed, 17 Feb 2016 11:07:27 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4dN-0003Eo-TR; Wed, 17 Feb 2016 11:07:22 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4476 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aW4dN-0006Ah-2f; Wed, 17 Feb 2016 11:07:21 -0500 Date: Wed, 17 Feb 2016 16:07:00 -0000 Message-Id: <83y4ajuxq1.fsf@gnu.org> From: Eli Zaretskii To: Doug Evans CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <001a113452243e6481052bece0b3@google.com> (message from Doug Evans on Wed, 17 Feb 2016 01:07:38 +0000) Subject: Re: [PATCH, doc RFA] Add "skip regexp" Reply-to: Eli Zaretskii References: <001a113452243e6481052bece0b3@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00520.txt.bz2 > Date: Wed, 17 Feb 2016 01:07:38 +0000 > From: Doug Evans > Cc: gdb-patches@sourceware.org > > Eli: Heads up, rewritten docs, needing re-approval. Thanks for the heads-up. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -127,6 +127,14 @@ show max-value-size > allocate for value contents. Prevents incorrect programs from > causing GDB to allocate overly large buffers. Default is 64k. > > +skip -file file > +skip -gfile file-glob-pattern > +skip -function function > +skip -rfunction regular-expression > + A generalized form of the skip command, with new support for > + glob-style file names and regular expressions for function names. > + Additionally, a file spec and a function spec may now be combined. > + This part is OK. > +@item -gfile @var{file-glob-pattern} > +@itemx -gfi @var{file-glob-pattern} > +Functions in files matching @var{file-glob-pattern} will be skipped > +over when stepping. > + > +@smallexample > +(gdb) skip -gfi utils/*.c > +@end smallexample Is there a way to protect wildcard characters? If so, I think we should mention it. > +For example, there is generally no need to step into C++ std::string C@t{++}, and "std::string" should be in @code. Also, this description should have a couple of @cindex entries, as readers are likely to look for it without remembering that the command's name is "skip". The documentation is OK with those fixed. Thanks.