Re: [PATCHv6] gdb: Change how frames are selected for 'frame' and 'info frame'.

Pedro Alves
2018-09-27T20:58:36Z

On 09/27/2018 12:06 AM, Andrew Burgess wrote:> Thanks for the review.
>
> This revision makes the following changes:
>
> - Addresses the two small grammatical errors, and removes the random
> comment line in the testsuite.
>
> - Rewrites the get_new_address function in the testsuite so that is
> actually does what it says on the tin (in line with your
> suggestion).
>
> - Extends the header comment on parse_frame_specification. While
> doing this I realised that due to the way this function is now
> used it can be simplified a lot. We now only handle a single
> argument. I'd rather not start extending the existing MI
> interface with new features at this point, and I didn't think
> keeping the more complex parse_frame_specification around "just in
> case" was good practice.
>
> It's because of this last change that I've posted the patch for
> another review. I think the change is sensible (and the tests pass),
> but I wanted another opinion.

I agree. LGTM.

Thanks,
Pedro Alves