From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26775 invoked by alias); 17 Aug 2018 18:57:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26759 invoked by uid 89); 17 Aug 2018 18:57:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:fencepo, Hx-spam-relays-external:sk:fencepo, H*r:eggs.gnu.org, H*r:4.71 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Aug 2018 18:57:33 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqjw6-0000UV-Le for gdb-patches@sourceware.org; Fri, 17 Aug 2018 14:57:30 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqjw6-0000UL-HZ; Fri, 17 Aug 2018 14:57:26 -0400 Received: from [176.228.60.248] (port=3966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fqjw6-0001qx-27; Fri, 17 Aug 2018 14:57:26 -0400 Date: Fri, 17 Aug 2018 18:57:00 -0000 Message-Id: <83y3d4g6sz.fsf@gnu.org> From: Eli Zaretskii To: Keith Seitz CC: gdb-patches@sourceware.org In-reply-to: (message from Keith Seitz on Fri, 17 Aug 2018 10:50:53 -0700) Subject: Re: [PATCH 9/9] C++ compile support References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <83in4hmkpt.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00434.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Keith Seitz > Date: Fri, 17 Aug 2018 10:50:53 -0700 > > * GDB now has experimental support for the compilation and injection of > C++ source code into the inferior. This beta release does not include > support for several language features, such as templates, constructors, > and operators. This is fine, thanks. > >> +* GDB now has experimental support for the compilation and injection of > >> + C++ source code into the inferior. This feature requires the GCC C++ > >> + plug-in available since GCC 7.1. > > > > The last sentence basically means "only on ELF platforms", right? So > > IMO this limitation should be stated explicitly, lest people get > > excited, and then get disappointed. > > I'm not sure how to answer this. That seems like enumerating all the dependencies > of every dependency GDB has (bfd, libiberty, bison, etc). The feature (like the > C compile feature already included) requires the compiler plug-in. Whatever that > plug-in supports is what GDB supports. It is okay to say that this is supported only on platforms where libcc1.so and the 'compile' command are available. My problem was with not qualifying this at all. > Would you like me to include something like: "Currently tested on x86_64 > GNU/Linux." Using "currently" is generally not advisable, as the meaning of that word changes with time. > >> +set debug compile-oracle > >> +show debug compile-oracle > >> + Control the display of debug output about symbol requests from > >> + the compiler plug-in. > >> + > >> +set debug compile-cplus-types > >> +show debug compile-cplus-types > >> + Control the display of debug output about C++ type conversion > >> + in the compile feature. > > > > I suggest to mention that these commands are only available/have > > effect if the C++ compilation is supported. > > Maybe this is better/clearer? > > set debug compile-cplus-types > show debug compile-cplus-types > Control the display of debug output about type conversion in the > C++ compile feature. Commands have no effect while compiling for > other languages. Yes, better. > Nonetheless, on second thought, it seems almost nonsensical to have a > special debug flag just for this. So I've removed the option and just > added the "oracle" debug output when the "normal" compile debug flag > is set. WDYT? OK. > Would you like me to repost this patch? That won't be needed, thanks.