From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33376 invoked by alias); 21 Nov 2018 12:37:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33365 invoked by uid 89); 21 Nov 2018 12:37:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*jhb, U*jhb X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Nov 2018 12:37:20 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPRks-0000cE-CA for gdb-patches@sourceware.org; Wed, 21 Nov 2018 07:37:19 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRkl-0000Up-GC; Wed, 21 Nov 2018 07:37:11 -0500 Received: from [176.228.60.248] (port=4468 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gPRkl-000567-3g; Wed, 21 Nov 2018 07:37:11 -0500 Date: Wed, 21 Nov 2018 12:37:00 -0000 Message-Id: <83y39mhain.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: jimw@sifive.com, gdb-patches@sourceware.org, palmer@sifive.com, jhb@freebsd.org In-reply-to: <20181121112335.GX16539@embecosm.com> (message from Andrew Burgess on Wed, 21 Nov 2018 11:23:35 +0000) Subject: Re: [PATCH] gdb/riscv: Add target description support References: <20181108160745.24600-1-andrew.burgess@embecosm.com> <20181114145756.GM16539@embecosm.com> <20181121112335.GX16539@embecosm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00349.txt.bz2 > Date: Wed, 21 Nov 2018 11:23:35 +0000 > From: Andrew Burgess > Cc: gdb-patches@sourceware.org, Palmer Dabbelt , > John Baldwin > > Eli, > > I believe I still need a doc review before I can merge this patch. > Could I ask you to take a look please. Sorry, I thought I already did. See below. > +The @samp{org.gnu.gdb.riscv.fpu} feature is optional. If present it ^ Please insert a comma where shown. > +should contain registers @samp{f0} through @samp{f31}, @samp{fflags}, > +@samp{frm}, and @samp{fcsr}. As with the cpu feature either the ^ And here. > +The @samp{org.gnu.gdb.riscv.virtual} feature is optional. If present ^ And here. > +it should contain registers that are not backed by real registers on > +the target but are instead virtual, where the register value is ^ And here. > +derived from other target state. In many ways these are like GDBs ^^^^ @value{GDBN}s > +The @samp{org.gnu.gdb.riscv.csr} feature is optional. If present it ^ Need a comma there. OK with these nits fixed. Thanks.