Re: Fix pressing down in the TUI (Re: [RFC 8.3 0/3] Some style fixes)

Tom Tromey
2019-03-15T15:33:58Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Otherwise this LGTM. I see get_plain_source_lines has similar
Pedro> code, so my immediate thought was to move that to a helper function,
Pedro> but there's a difference that makes that unviable -- get_plain_source_lines
Pedro> always wants to open the source file first, while here we can avoid
Pedro> it unless line_charpos is 0.

I don't really like having to open the file like this on every step, and
especially not just do call some other function for its side-effects.
However, this is the status quo ante, so the patch seems fine; and I
made a note to fix this up eventually.

Tom