Re: [RFC 8.3 0/3] Some style fixes

Eli Zaretskii
2019-03-10T13:14:56Z

> Date: Sat, 09 Mar 2019 08:17:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> CC: gdb-patches@sourceware.org
>
> > From: Tom Tromey <tromey@adacore.com>
> > Date: Fri, 8 Mar 2019 14:04:30 -0700
> >
> > This series fixes some of the TUI/styling regressions noted by Pedro.
> > I would like to push this to the 8.3 branch as well.
> >
> > Patch #2 is a new feature that Eli mentioned. Since it's an addition
> > to a feature that is also new in 8.3, it seemed reasonable to do at
> > this time.
> >
> > Let me know what you think.
>
> Thanks. I won't have time today to test the patch, but I will
> certainly try tomorrow.

Tried that now. The new "set style sources" toggle works nicely,
thanks. However, the artifacts I saw in the TUI display in the
pretest are still there. In particular, the right-hand side of the
frame of the source window still gets overwritten when stepping
through the inferior's code, and it looks like the newline is not
echoed after commands typed in the command window. E.g., here's what
I see after starting Emacs with "start -Q" and then typing "print 42":

Type "apropos word" to search for commands related to "word"...
Reading symbols from d:/usr/eli/emacs-master_2019-03-04/src/emacs.exe...
(gdb) start -QTemporary breakpoint 1 at 0x114b4b7: file emacs.c, line 839.
Starting program: d:\usr\eli\emacs-master_2019-03-04\src\emacs.exe -Q

Temporary breakpoint 1, main (argc=2, argv=0x9c11a0) at emacs.c:839
(gdb) p 42$1 = 42

As you see, the newlines after "start -Q" and "p 42" were not
output/acted upon, so the following text is displayed on the same
screen line.

Thanks.