From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154605-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 45059 invoked by alias); 14 Mar 2019 15:36:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 45050 invoked by uid 89); 14 Mar 2019 15:36:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*tom
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 15:36:42 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:39685)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1h4SPN-0000wa-MS; Thu, 14 Mar 2019 11:36:39 -0400
Received: from [176.228.60.248] (port=4280 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1h4SPM-0001Xp-QM; Thu, 14 Mar 2019 11:36:37 -0400
Date: Thu, 14 Mar 2019 15:36:00 -0000
Message-Id: <83y35h1n9s.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
CC: tom@tromey.com, tromey@adacore.com, gdb-patches@sourceware.org
In-reply-to: <f93b619f-5a27-2771-b3d7-fa96e5e69040@redhat.com> (message from	Pedro Alves on Thu, 14 Mar 2019 14:40:37 +0000)
Subject: Re: [RFC 8.3 0/3] Some style fixes
References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <83k1h23hat.fsf@gnu.org> <87tvg5fxzp.fsf@tromey.com> <f93b619f-5a27-2771-b3d7-fa96e5e69040@redhat.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00293.txt.bz2

> Cc: tromey@adacore.com, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 Mar 2019 14:40:37 +0000
> 
> On 03/14/2019 12:20 PM, Tom Tromey wrote:
> >>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > Eli> +#ifdef __MINGW32__
> > Eli> +#include <windows.h>
> > Eli> +static SHORT ncurses_norm_attr;
> > Eli> +#endif
> > 
> > I'd somewhat prefer it if the definition were in a separate block after
> > all the includes.
> 
> Me too.  It would help with the "namespace gdb" effort as well,
> since the variable will be braced under "namespace gdb" while
> the header won't.

Thanks for the review.  I made the requested change and pushed to both
branches.