From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106364 invoked by alias); 30 Jul 2019 14:59:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106168 invoked by uid 89); 30 Jul 2019 14:59:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=U*gdb-patches, gdb-patches@sourceware.org, gdbpatchessourcewareorg, sk:gdb-pat X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jul 2019 14:59:48 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hsTbO-0008VT-KU; Tue, 30 Jul 2019 10:59:46 -0400 Received: from [176.228.60.248] (port=2531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hsTbO-0005qR-3y; Tue, 30 Jul 2019 10:59:46 -0400 Date: Tue, 30 Jul 2019 14:59:00 -0000 Message-Id: <83y30fin55.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: gdb-patches@sourceware.org In-reply-to: <20190730015121.205269-1-cbiesinger@google.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH v5] Add Objfile.lookup_{global,static}_symbol functions References: <39420ba4-a5f2-783b-5a8a-2a10e08cb05a@simark.ca> <20190730015121.205269-1-cbiesinger@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00656.txt.bz2 > Date: Mon, 29 Jul 2019 20:51:21 -0500 > From: "Christian Biesinger via gdb-patches" > Cc: Christian Biesinger > > Thanks Simon; fixed. I pushed the below version. > > This is essentially the inverse of Symbol.objfile. This allows > handling different symbols with the same name (but from different > objfiles) and can also be faster if the objfile is known. > > gdb/ChangeLog: > > 2019-07-29 Christian Biesinger > > * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol. > * python/py-objfile.c (objfpy_lookup_global_symbol): New function. > (objfpy_lookup_static_symbol): New function. > (objfile_object_methods): Add new functions. > > gdb/doc/ChangeLog: > > 2019-07-29 Christian Biesinger > > * python.texi (Objfiles In Python): Document new functions > Objfile.lookup_{global,static}_symbol. > > gdb/testsuite/ChangeLog: > > 2019-07-29 Christian Biesinger > > * gdb.python/py-objfile.c: Add global and static vars. > * gdb.python/py-objfile.exp: Test new functions Objfile. > lookup_global_symbol and lookup_static_symbol. Thanks, the documentation parts are OK.