From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id B3F333947C31
 for <gdb-patches@sourceware.org>; Wed, 17 Jun 2020 18:28:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3F333947C31
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49684)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jlcn8-0006E7-9m; Wed, 17 Jun 2020 14:28:06 -0400
Received: from [176.228.60.248] (port=4306 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jlcn7-0002Ob-A7; Wed, 17 Jun 2020 14:28:05 -0400
Date: Wed, 17 Jun 2020 21:27:50 +0300
Message-Id: <83y2olzgwp.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <360af15dc7ea2e2e20f2b9ff6529467b7e0a0614.1592415322.git.andrew.burgess@embecosm.com>
 (message from Andrew Burgess on Wed, 17 Jun 2020 18:38:08 +0100)
Subject: Re: [PATCH 4/5] gdb/python: New method to access list of register
 groups
References: <cover.1592415321.git.andrew.burgess@embecosm.com>
 <360af15dc7ea2e2e20f2b9ff6529467b7e0a0614.1592415322.git.andrew.burgess@embecosm.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2020 18:28:07 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 17 Jun 2020 18:38:08 +0100
> 
> gdb/ChangeLog:
> 
> 	* NEWS: Mention additions to Python API.
> 	* python/py-arch.c (archpy_register_groups): New function.
> 	(arch_object_methods): Add 'register_groups' method.
> 	* python/py-registers.c (reggroup_iterator_object): New struct.
> 	(reggroup_object): New struct.
> 	(gdbpy_new_reggroup): New function.
> 	(gdbpy_reggroup_to_string): New function.
> 	(gdbpy_reggroup_name): New function.
> 	(gdbpy_reggroup_iter): New function.
> 	(gdbpy_reggroup_iter_next): New function.
> 	(gdbpy_new_reggroup_iterator): New function
> 	(gdbpy_initialize_registers): Register new types.
> 	(reggroup_iterator_object_type): Define new Python type.
> 	(gdbpy_reggroup_getset): New static global.
> 	(reggroup_object_type): Define new Python type.
> 	* python/python-internal.h
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.python/py-arch-reg-groups.exp: New file.
> 
> gdb/doc/ChangeLog:
> 
> 	* gdb.texi (Registers): Add @anchor for 'info registers
> 	<reggroup>' command.
> 	* python.texi (Architectures In Python): Document new
> 	register_groups method.
> 	(Registers In Python): Document two new object types related to
> 	register groups.

The documentation parts are OK, thanks.