From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id v9CJKrOFJmFQCQAAWB0awg (envelope-from ) for ; Wed, 25 Aug 2021 14:02:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 9D3A01EE1B; Wed, 25 Aug 2021 14:02:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F2AB01EDF0 for ; Wed, 25 Aug 2021 14:02:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 687EC385B805 for ; Wed, 25 Aug 2021 18:02:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 687EC385B805 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629914546; bh=k8YV5pl4hbtxyP3GwgdSXl/Wl8TEreVKPQWQaGqGdoc=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OAZAdaxkMbEJZbYZ6HFbRI6V4GVVwHnNMjC0XCR7DbvS0oQPalQhUifGdt6ZtxVMB khW71P/9QVgCoWhZ3uxImilI00zK0xQsb7GDkL6u8Lo6U7KjkoitZJEp5LKPunLSfS LXzEFoE1Bym+JGvuHJQ4Nwb7fDEGVHBsbDCif0Po= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 68440385B836 for ; Wed, 25 Aug 2021 18:01:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68440385B836 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55210) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIxDk-000839-Kx; Wed, 25 Aug 2021 14:01:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2099 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIxDk-0005NH-3e; Wed, 25 Aug 2021 14:01:52 -0400 Date: Wed, 25 Aug 2021 21:01:50 +0300 Message-Id: <83y28ptnch.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <20210825172719.3814152-1-andrew.burgess@embecosm.com> (message from Andrew Burgess on Wed, 25 Aug 2021 18:27:19 +0100) Subject: Re: [PATCHv2] gdb/python: add facility to add values into the history References: <874kbfaon0.fsf@tromey.com> <20210825172719.3814152-1-andrew.burgess@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Wed, 25 Aug 2021 18:27:19 +0100 > > +* Python API > + > + ** New function gdb.add_history(), which takes a gdb.Value object > + and adds the value to GDB's history list. An integer, the index ^^^^^^^^^ "its value", right? > +@findex gdb.add_history You don''t need @findex here, since @defun produces that automatically. > +Append @var{value}, an instance of @code{gdb.Value} (@pxref{Values > +From Inferior}), to @value{GDBN}'s value history (@pxref{Value This sounds like it appends the Python object to the history, but in reality it appends its value, right? > +History}) and return an integer, its history number. If @var{value} ^ Comma missing there. Thanks.