From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SQsjLusbHWJKVgAAWB0awg (envelope-from ) for ; Mon, 28 Feb 2022 14:00:59 -0500 Received: by simark.ca (Postfix, from userid 112) id A71181F3C8; Mon, 28 Feb 2022 14:00:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 404981F0D2 for ; Mon, 28 Feb 2022 14:00:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 994BD3858406 for ; Mon, 28 Feb 2022 19:00:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 994BD3858406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1646074858; bh=NRGJXZhhAjc8rss/6415Qtt8XW/BHQxFGXn5G07bCCQ=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FdH2mtoVdJc9w3X3DaFPMNMIQVx0GfRf7IJ108+vD0tl5/Qgmsghm/Fj7+tccAw3k dBZjLJPXHkgaPqaOrgl284AVLQ97LFDrm4XEm48/+so/n69f4vLYRGpL2AW+j4BnfS Jj5n9s6o0hQ1WMiXsYi5DYMqGx8hYASEU86vXbSY= Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id 5B60E3858418 for ; Mon, 28 Feb 2022 19:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B60E3858418 Received: from [2001:470:142:3::e] (port=46338 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOlFj-0005NV-KE; Mon, 28 Feb 2022 14:00:11 -0500 Received: from [87.69.77.57] (port=2283 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOlFh-0002TH-Fy; Mon, 28 Feb 2022 14:00:11 -0500 Date: Mon, 28 Feb 2022 20:59:59 +0200 Message-Id: <83y21ulsuo.fsf@gnu.org> To: Tom Tromey In-Reply-To: <20220228183304.1162089-6-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Mon, 28 Feb 2022 11:33:04 -0700) Subject: Re: [PATCH 5/5] Handle non-ASCII identifiers in Ada References: <20220228183304.1162089-1-tromey@adacore.com> <20220228183304.1162089-6-tromey@adacore.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Mon, 28 Feb 2022 11:33:04 -0700 > From: Tom Tromey via Gdb-patches > Cc: Tom Tromey > > +for c in range(0, 0x10FFFF): > + process_codepoint(c) This script assumes that the version of Python which will run it is up-to-date with the latest Unicode Character Database (UCD), right? Is that a good assumption? Wouldn't it be better to process the UCD from the latest Unicode Standard directly? > +@kindex set ada source-charset > +Set the source character set for Ada. The character set must be one > +of the ones supported by GNAT. Because this setting affects the "must be one of the ones supported" sounds awkward. Can you reword it? Other than that, the documentation parts are okay. Thanks.