Re: Two observations using GDB 13 snapshot

Christian Biesinger via Gdb-patches
2023-01-03T19:46:18Z

On Fri, Dec 30, 2022 at 9:32 AM Eli Zaretskii via Gdb-patches
<gdb-patches@sourceware.org> wrote:
>
> > Date: Thu, 29 Dec 2022 15:22:31 -0500
> > Cc: gdb-patches@sourceware.org, luis.machado@arm.com
> > From: Simon Marchi <simark@simark.ca>
> > Googling a bit, it looks
> > like tolower can be slow on Windows when a locale (other than "C") is
> > used:
> >
> > https://stackoverflow.com/questions/36686381/windows-c-runtime-toupper-slow-when-locale-set
> > https://bugs.php.net/bug.php?id=45265
>
> I couldn't see any numbers there about the performance of tolower
> itself, i.e. how many ms per call does it take on Windows vs glibc.
> But if someone can show a patch to try to eliminate the calls to
> tolower, I can try and see if it affects the processing time in this
> scenario.

Seems like that could be tested by running gdb with LANG=C and/or
commenting out the setlocale calls in gdb/main.c?

Christian