Re: Two observations using GDB 13 snapshot

Christian Biesinger via Gdb-patches
2023-01-03T20:35:55Z

On Tue, Jan 3, 2023 at 3:17 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Christian Biesinger <cbiesinger@google.com>
> > Date: Tue, 3 Jan 2023 14:44:56 -0500
> > Cc: Simon Marchi <simark@simark.ca>, tom@tromey.com, gdb-patches@sourceware.org,
> > luis.machado@arm.com
> >
> > > > https://stackoverflow.com/questions/36686381/windows-c-runtime-toupper-slow-when-locale-set
> > > > https://bugs.php.net/bug.php?id=45265
> > >
> > > I couldn't see any numbers there about the performance of tolower
> > > itself, i.e. how many ms per call does it take on Windows vs glibc.
> > > But if someone can show a patch to try to eliminate the calls to
> > > tolower, I can try and see if it affects the processing time in this
> > > scenario.
> >
> > Seems like that could be tested by running gdb with LANG=C and/or
> > commenting out the setlocale calls in gdb/main.c?
>
> Setting LANG in the environment doesn't have any effect on Windows,
> since the Windows version of setlocale is insensitive to LANG and LC_*
> environment variables.

Well you could still try commenting out the setlocale call.

In terms of the code, may be worth trying TOLOWER from
include/safe-ctype.h instead of tolower()

Christian