From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kDTaH7YLLGQN7yIAWB0awg (envelope-from ) for ; Tue, 04 Apr 2023 07:36:22 -0400 Received: by simark.ca (Postfix, from userid 112) id 807521E15D; Tue, 4 Apr 2023 07:36:22 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=rsfQQasL; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 37FFE1E0D3 for ; Tue, 4 Apr 2023 07:36:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 669CF3858425 for ; Tue, 4 Apr 2023 11:36:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669CF3858425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680608180; bh=Zib8C1tq0eMKNQGQFQ6eONQeb73ssGdjYL7CtiWNew4=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rsfQQasL4jIVtRUbRmSo4ZLYh/fw5LHcUL0RIwXpl70HcfJKQ2D8wimj5ZB8Arpc1 R5Dzluo5qNwz+CDh0xdt7zoAk0K3VnCWDdg+NVydf/6lLya0/H4FtYUao+6VE/dy5+ 3+m5+0q2S+6zJkJkg0uMAj6RXU8HOIGTBRsJvOJA= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 58A15385800A for ; Tue, 4 Apr 2023 11:36:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58A15385800A Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjexE-0002zt-MR; Tue, 04 Apr 2023 07:36:00 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjexB-0007td-2y; Tue, 04 Apr 2023 07:35:59 -0400 Date: Tue, 04 Apr 2023 14:36:22 +0300 Message-Id: <83y1n7ubex.fsf@gnu.org> To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Tue, 4 Apr 2023 09:21:03 +0100) Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation References: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Cc: Andrew Burgess > Date: Tue, 4 Apr 2023 09:21:03 +0100 > From: Andrew Burgess via Gdb-patches > > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -6909,7 +6909,7 @@ > @code{RuntimeError} exception if it is invalid. > @end defun > > -@defun DisassembleInfo.__init__ (info) > +@defun DisassembleInfo.__init__ (@var{info}) You consistently rewrite the Texinfo source to use @var inside the argument lists of a @defun. I already asked why, as I don't think this is required. I don't think you replied. So once again: why are you doing this? what problems happen if you don't? Otherwise, this is fine. Thanks. Reviewed-By: Eli Zaretskii