Re: [commit] Fix prototype related breakage in go32-nat.c

Pedro Alves
2009-04-11T18:15:25Z

On Saturday 11 April 2009 18:59:20, Eli Zaretskii write:
> Didn't we agree at the time that the prototypes should be corrected as
> well?

You're probably confused... those functions were changed
much prior to that agreement:

http://sourceware.org/ml/gdb-patches/2008-08/msg00403.html
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/go32-nat.c.diff?r1=1.60&r2=1.61&cvsroot=src&f=h

Obviously, it was a simple lapse, one that wouldn't happen if
these functions weren't needlessly forward declared.

(and we agreed to *keep* the prototypes. Obviously, if they
are to keep, they need to be adjusted, there's no need to agree
on that)

> Committed.
>
>
> 2009-04-11 Eli Zaretskii <eliz@gnu.org>
>
> * go32-nat.c (go32_attach, go32_detach:) Fix prototypes to be

^ Typo.

> consistent with the change from 2009-03-17.

^^^^^^^^^^
Not that it matter a thing, but, ... wrong date, the change of
the 17th only concerned target_kill.

>
> Index: gdb/go32-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/go32-nat.c,v
> retrieving revision 1.67
> diff -u -r1.67 go32-nat.c
> --- gdb/go32-nat.c 17 Mar 2009 19:28:08 -0000 1.67
> +++ gdb/go32-nat.c 11 Apr 2009 17:55:06 -0000
> @@ -167,8 +167,8 @@
> static int prog_has_started = 0;
> static void go32_open (char *name, int from_tty);
> static void go32_close (int quitting);
> -static void go32_attach (char *args, int from_tty);
> -static void go32_detach (char *args, int from_tty);
> +static void go32_attach (struct target_ops *ops, char *args, int from_tty);
> +static void go32_detach (struct target_ops *ops, char *args, int from_tty);
> static void go32_resume (struct target_ops *ops,
> ptid_t ptid, int step,
> enum target_signal siggnal);
>

--
Pedro Alves