Re: [commit] Fix prototype related breakage in go32-nat.c

Eli Zaretskii
2009-04-11T19:27:50Z

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sat, 11 Apr 2009 19:16:09 +0100
>
> On Saturday 11 April 2009 18:59:20, Eli Zaretskii write:
> > Didn't we agree at the time that the prototypes should be corrected as
> > well?
>
> You're probably confused... those functions were changed
> much prior to that agreement:

Sorry. It's easy to become confused when modified functions are not
mentioned in the logs.

> it was a simple lapse, one that wouldn't happen if these functions
> weren't needlessly forward declared.

We agreed to keep the prototypes, so I'm really surprised that this
issue is brought up again. What is the purpose of reviving this dead
horse? As you point out correctly, the problem happened before the
dispute, so why did you need this ``told you so'' reminder?

Btw, it's obvious that no one tried to compile go32-nat.c since then.
How can we be sure we don't break targets if they are not regularly
built? Didn't Andrew set up such a build at the time?

> (and we agreed to *keep* the prototypes. Obviously, if they
> are to keep, they need to be adjusted, there's no need to agree
> on that)

We don't need to agree on that, but we do need to keep them adjusted,
and I think it's the job of whoever makes the change to take care of
that.

> > 2009-04-11 Eli Zaretskii <eliz@gnu.org>
> >
> > * go32-nat.c (go32_attach, go32_detach:) Fix prototypes to be
>
> ^ Typo.
>
> > consistent with the change from 2009-03-17.
>
> ^^^^^^^^^^
> Not that it matter a thing, but, ... wrong date, the change of
> the 17th only concerned target_kill.

Thanks, I fixed these.