From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28897 invoked by alias); 11 Apr 2009 19:27:50 -0000 Received: (qmail 28889 invoked by uid 22791); 11 Apr 2009 19:27:50 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Apr 2009 19:27:44 +0000 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KHY00G00ABXRN00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Sat, 11 Apr 2009 22:27:20 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.240.185]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KHY002VUBDJHX40@i-mtaout7.012.net.il>; Sat, 11 Apr 2009 22:27:20 +0300 (IDT) Date: Sat, 11 Apr 2009 19:27:00 -0000 From: Eli Zaretskii Subject: Re: [commit] Fix prototype related breakage in go32-nat.c In-reply-to: <200904111916.10115.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ws9rng84.fsf@gnu.org> References: <834owvoyvb.fsf@gnu.org> <200904111916.10115.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00219.txt.bz2 > From: Pedro Alves > Date: Sat, 11 Apr 2009 19:16:09 +0100 > > On Saturday 11 April 2009 18:59:20, Eli Zaretskii write: > > Didn't we agree at the time that the prototypes should be corrected as > > well? > > You're probably confused... those functions were changed > much prior to that agreement: Sorry. It's easy to become confused when modified functions are not mentioned in the logs. > it was a simple lapse, one that wouldn't happen if these functions > weren't needlessly forward declared. We agreed to keep the prototypes, so I'm really surprised that this issue is brought up again. What is the purpose of reviving this dead horse? As you point out correctly, the problem happened before the dispute, so why did you need this ``told you so'' reminder? Btw, it's obvious that no one tried to compile go32-nat.c since then. How can we be sure we don't break targets if they are not regularly built? Didn't Andrew set up such a build at the time? > (and we agreed to *keep* the prototypes. Obviously, if they > are to keep, they need to be adjusted, there's no need to agree > on that) We don't need to agree on that, but we do need to keep them adjusted, and I think it's the job of whoever makes the change to take care of that. > > 2009-04-11 Eli Zaretskii > > > > * go32-nat.c (go32_attach, go32_detach:) Fix prototypes to be > > ^ Typo. > > > consistent with the change from 2009-03-17. > > ^^^^^^^^^^ > Not that it matter a thing, but, ... wrong date, the change of > the 17th only concerned target_kill. Thanks, I fixed these.