From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71905-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28758 invoked by alias); 9 Apr 2010 08:22:16 -0000
Received: (qmail 28549 invoked by uid 22791); 9 Apr 2010 08:22:14 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 08:22:05 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L0L00400OK50700@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Apr 2010 11:21:59 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0L000XUOKHZ7A0@a-mtaout22.012.net.il>; Fri, 09 Apr 2010 11:21:54 +0300 (IDT)
Date: Fri, 09 Apr 2010 08:22:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
In-reply-to: <1270786615-29934-1-git-send-email-crquan@gmail.com>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, teawater@gmail.com, brobecker@adacore.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wrwhyr18.fsf@gnu.org>
References: <1270786615-29934-1-git-send-email-crquan@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00224.txt.bz2

> From: crquan@gmail.com
> Cc: Joel Brobecker <brobecker@adacore.com>,
> 	Eli Zaretskii <eliz@gnu.org>
> Date: Fri,  9 Apr 2010 12:16:55 +0800
> 
> +* Changed commands
> +
> +disassemble
> +  The disassemble command, add "start,+length" form of two arguments support.
> +
>  *** Changes in GDB 7.1
>  
>  * C++ Improvements
> @@ -334,8 +339,9 @@ or the "condition" command is available.
>  the target for evaluation using the same bytecode format as is used
>  for tracepoint actions.
>  
> -* "disassemble" command with a /r modifier, print the raw instructions
> -in hex as well as in symbolic form.
> +* The "disassemble" command with an optional /r modifier, print the raw
> +instructions in hex as well as in symbolic form; optional /m modifier to
> +print mixed source+assembly.

Thanks.  But please use the style we use in other NEWS entries.
Something like "The disassemble command now supports ..." etc.

> +arguments specify a range of addresses, in the form of "start,end" or
> +"start,+length", stand for [start,end) and [start,start+length), (first
> +inclusive, second exclusive) to dump.  In that case, the name of the
> +function is also printed (since there could be several functions in the
> +given range).

I suggest to rephrase as follows:

  arguments specify a range of addresses to dump, in one of two forms:

  @table @code
  @item @var{start},@var{end}
  the addresses from @var{start} (inclusive) to @var{end} (exclusive)
  @item @var{start},+@var{length}
  the addresses from @var{start} (inclusive) to
  @code{@var{start}+@var{length}} (exclusive).
  @end table

  @noindent
  When 2 arguments are specified, the name of the function is also
  printed (since there could be several functions in the given range).

Note that I used @var{start},@var{end}}, instead of using double
quotes (which is generally a no-no in Texinfo sources).