From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79790-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32076 invoked by alias); 17 Mar 2011 19:15:26 -0000
Received: (qmail 32068 invoked by uid 22791); 17 Mar 2011 19:15:25 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Mar 2011 19:15:18 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LI700K00UR1Z600@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 17 Mar 2011 21:15:13 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.107.218]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LI700KBAUTB4YH0@a-mtaout22.012.net.il>; Thu, 17 Mar 2011 21:15:13 +0200 (IST)
Date: Thu, 17 Mar 2011 19:47:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] PR python/12149 (stderr output directed to stdout)
In-reply-to: <m31v25slqi.fsf@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wrjxsgn0.fsf@gnu.org>
References: <m31v25slqi.fsf@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00903.txt.bz2

> From: Phil Muldoon <pmuldoon@redhat.com>
> Date: Thu, 17 Mar 2011 17:25:09 +0000
> 
> This patch addresses the bug in python/12149 where output from the Python
> sys.stderr was being directed to stdout within GDB.  In this patch I
> have updated gdb.write and flush to take a stream argument, and also
> created a new class to deal with error output.

Thanks.

> +@item STDERR
> +@value{GDBN}'s error stream.

"standard error", I think.

> +@item STDLOG
> +@value{GDBN}'s log stream.

This may need a word or two of explanation, because it's not a
standard stream like stdout and stderr.  It goes to where "set
logging" directs it, right?  If so, how about a cross-reference to
where the logging facility is described?

> +Flush a @value{GDBN} paginated stream.  The optional @var{stream}
> +determines the stream to flush.  The default stream is @value{GDBN}'s
> +standard output stream.  Possible stream values are:

Are you sure the reader will know the effect of "flushing" a strem
without any explanations?