Re: [RFA/mingw32] environment variables are case-insensitive on win32

Eli Zaretskii
2012-12-07T09:30:16Z

> Date: Fri, 7 Dec 2012 10:22:02 +0100
> From: Jerome Guitton <guitton@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> Eli Zaretskii (eliz@gnu.org):
>
> > Configure-time test is not good enough, as the binary could then be
> > run in a different environment.
> >
> > How about making it case-insensitive for Cygwin as well?
>
> I ended up implementing Pedro's suggestion (a run-time test) but it
> does not work in the case of Cygwin; getenv/setenv acts as if we add a
> case-sensitive environment, but we use CreateProcess to create the
> inferior, so we end up with a case-insensitive environment for the
> inferior. So making it case-insensitive is indeed what makes sense.
>
> Last versions of the patch in attachment, along with the testcase.
> Fully tested on x86_64-linux; partially tested on Cygwin (e.g. without
> gdb.threads) amd mingw32 (testenv.exp only).
>
> Any comments?

The attached patch still uses a run-time test. Did you attach a wrong
patch?