From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126292-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17291 invoked by alias); 22 Sep 2015 16:59:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17270 invoked by uid 89); 22 Sep 2015 16:59:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Sep 2015 16:59:31 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NV3009007VI2400@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 22 Sep 2015 19:59:28 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NV30089K8J4Y770@a-mtaout23.012.net.il>; Tue, 22 Sep 2015 19:59:28 +0300 (IDT)
Date: Tue, 22 Sep 2015 16:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] [PR breakpoints/18275] Introduce dprintf-flush-function for call-style dprintfs
In-reply-to: <5601776A.3030903@ericsson.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wpvil79f.fsf@gnu.org>
References: <1441827156-8518-1-git-send-email-simon.marchi@ericsson.com> <5601776A.3030903@ericsson.com>
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg00532.txt.bz2

> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Tue, 22 Sep 2015 11:44:42 -0400
> 
> > gdb/ChangeLog:
> > 
> > 	PR breakpoints/18275
> > 	* breakpoint.c (update_dprintf_command_list): Add call to the
> > 	flush function to the command list, factor out code.
> > 	(_initialize_breakpoint): Register set/show
> > 	dprintf-flush-function.
> > 	(dprintf_flush_function): New global.
> > 	(get_dprintf_call_print_line): New function.
> > 	(get_dprintf_call_flush_line): New function.
> > 	* NEWS: Mention set/show dprintf-flush-function.
> > 
> > gdb/testsuite/ChangeLog:
> > 
> > 	PR breakpoints/18275
> > 	* gdb.base/dprintf-flush.exp: New file.
> > 	* gdb.base/dprintf-flush.c: New file.
> > 	* gdb.base/dprintf.exp: Test error message when dprintf-function
> > 	is empty.
> > 
> > gdb/doc/ChangeLog:
> > 
> > 	PR breakpoints/18275
> > 	* gdb.texinfo (Dynamic Printf): Document set
> > 	dprintf-flush-function.

The documentation parts are OK.

Thanks.