From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102474 invoked by alias); 27 Jul 2017 17:10:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102462 invoked by uid 89); 27 Jul 2017 17:10:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 17:10:53 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1damJG-00017m-CT for gdb-patches@sourceware.org; Thu, 27 Jul 2017 13:10:51 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1damIx-0000z2-W7; Thu, 27 Jul 2017 13:10:32 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2430 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1damIw-0000rW-C1; Thu, 27 Jul 2017 13:10:31 -0400 Date: Thu, 27 Jul 2017 17:10:00 -0000 Message-Id: <83wp6t4xhk.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, palves@redhat.com, simon.marchi@polymtl.ca In-reply-to: <20170727033531.23066-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Wed, 26 Jul 2017 23:35:31 -0400) Subject: Re: [PATCH v2] Implement the ability to set/unset environment variables to GDBserver when starting the inferior Reply-to: Eli Zaretskii References: <20170629194106.23070-1-sergiodj@redhat.com> <20170727033531.23066-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00428.txt.bz2 > From: Sergio Durigan Junior > Cc: Pedro Alves , > Simon Marchi , > Eli Zaretskii , > Sergio Durigan Junior > Date: Wed, 26 Jul 2017 23:35:31 -0400 > > Changes from v1: > > - Implement suggestions by Simon. > > - Improve gdb_environ::unset (use std::remove). > > - Implement the ability to unset environment variables in the remote > target. > > - Implement hex2str and str2hex. > > - Extend unittest, testcase and documentation. OK for the documentation parts. Thanks.