From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102776 invoked by alias); 14 Aug 2017 15:07:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99934 invoked by uid 89); 14 Aug 2017 15:07:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 15:06:59 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhGxB-0005lw-RZ for gdb-patches@sourceware.org; Mon, 14 Aug 2017 11:06:58 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhGxB-0005lq-O1; Mon, 14 Aug 2017 11:06:53 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4291 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhGxB-0000DN-7K; Mon, 14 Aug 2017 11:06:53 -0400 Date: Mon, 14 Aug 2017 15:07:00 -0000 Message-Id: <83wp66gpdj.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20170814034030.20863-2-tom@tromey.com> (message from Tom Tromey on Sun, 13 Aug 2017 21:40:18 -0600) Subject: Re: [RFA v2 01/13] Rationalize "backtrace" command line parsing Reply-to: Eli Zaretskii References: <20170814034030.20863-1-tom@tromey.com> <20170814034030.20863-2-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00303.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Sun, 13 Aug 2017 21:40:18 -0600 > > doc/ChangeLog > 2017-08-13 Tom Tromey > > * gdb.texinfo (Backtrace): Describe options individually. Thanks, I have a couple of comments to the documentation part. > +To print a backtrace of the entire stack, use the @code{backtrace} > +command, or its alias @code{bt}. This command will print one line per > +frame for all frames in the stack. "All" is only by default, right? > +The @code{backtrace} command can accept some arguments: > + > +@table @code > +@item @var{n} > +@itemx @var{n} > +Print only the innermost @var{n} frames. > + > +@item -@var{n} > +@itemx -@var{n} > +Print only the outermost @var{n} frames. > + > +@item full > +Print the values of the local variables also. I think we should say explicitly that "full" and the numbers can be combined. Also, I would say somewhere than N is a positive number. The documentation patch is OK with these minor nits fixed.