From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4905 invoked by alias); 12 Mar 2019 17:29:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4785 invoked by uid 89); 12 Mar 2019 17:29:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=tomorrow X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 17:29:09 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3lD9-0007GP-6D; Tue, 12 Mar 2019 13:29:07 -0400 Received: from [176.228.60.248] (port=2855 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h3lD7-0004kR-Gv; Tue, 12 Mar 2019 13:29:06 -0400 Date: Tue, 12 Mar 2019 17:29:00 -0000 Message-Id: <83wol42e8y.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org, ssbssa@yahoo.de In-reply-to: <87o96g3upj.fsf@tromey.com> (message from Tom Tromey on Tue, 12 Mar 2019 10:48:08 -0600) Subject: Re: [RFC 8.3 0/3] Some style fixes References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00249.txt.bz2 > From: Tom Tromey > Cc: Hannes Domani > Date: Tue, 12 Mar 2019 10:48:08 -0600 > > Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when > Hannes> list'ing some source code, resulting in an endless loop. > Hannes> See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me. > > Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything. > Hannes> (that's just a very minor nuisance) > > Hannes> 3) Again in TUI, scrolling right handles TABS and escaped characters as single characters, > Hannes> which just looks weird. > > Thanks, I will take a look at these. I'm working on 2) and 3), and have already solved 90% of the problem (the last 10% are some tricky corner cases with TABs). Hope to have a tested patch tomorrow.