From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AuGuGqIoLWXaUC8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 08:12:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=XCqqfHhC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5E25B1E0C1; Mon, 16 Oct 2023 08:12:18 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D0E5C1E00F for ; Mon, 16 Oct 2023 08:12:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AE97385703F for ; Mon, 16 Oct 2023 12:12:15 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7A5573858D37 for ; Mon, 16 Oct 2023 12:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A5573858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A5573858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697458325; cv=none; b=K1Z8xocdVndNCtpoSdcyty6GCjmwG3xF30MoxBApgAJ/cKelaen/RSDQkLuAqarp061B+zzRx3TQDUe4D3lWglbDcJbLIsoSVE8r5GQ5esQNy9dU96884dQzGWYlfz/v+S+mwbnHcxuC4flRAQq9utUyVXwNnZjhiiPiVPKM/uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697458325; c=relaxed/simple; bh=NFWR0BMtF9aGtmfoGSS0vXRitp+uInhT7V9w1iTs9Yk=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=JHbKptJUtN7Bfpip2xVZp9EVnRTIfeScciLJROg+ZFFtnhtzce6RNaQSbxzoXW47L8s+x9n6NmZVkdBabp/WL3WNAD6ZWo1QI3/A4MCZ5mlHD9b5j3UjqzRHGOLJgVazfmdmDQ4d5KCn5QrBrdKv0i1pbYkcbUtTQXH3lPKgHj4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsMS4-0000xk-05; Mon, 16 Oct 2023 08:12:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ecU1r1KUleEOBgmZaf6sJz96SEcYIvuwgv8yPf72tow=; b=XCqqfHhC1TQK COwWQQx2wwtmf4L94qtvaNdkLSt+uAxjmFRsTYSZ372PoY4f/nC0JvTKXNZPKQAdb6DW7hpmVL+41 J/Cs8hYW3eXNZfJZGvITTXOAOL1ApTsPgS5zkFgrSBaunJRFWibQaGSEeIRDhnmk82h3f6GPCIvzF TRYRcUyOxEQdGojOsfjCeD6aXuU/H/SpdX2jlaYY5/8vi2l6XF5Xx7ilXLUrVFW//dbNY4f+YirYC YSVtkOGBsuooWtpv81mrfuB/0asOuKa3vfF0NK9e4PphzqGlUp98pQMksYKGd4RP7lgWwzTpUWCSc kmsXXZA3wgGipebnTY2OaQ==; Date: Mon, 16 Oct 2023 15:11:49 +0300 Message-Id: <83wmvmojga.fsf@gnu.org> From: Eli Zaretskii To: Simon Farre Cc: gdb-patches@sourceware.org, tromey@adacore.com In-Reply-To: <20231016115026.133574-1-simon.farre.cx@gmail.com> (message from Simon Farre on Mon, 16 Oct 2023 13:50:26 +0200) Subject: Re: [PATCH v1] [gdb/python]: Add StepEndedEvent (simplifies DAP) References: <20231016115026.133574-1-simon.farre.cx@gmail.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Simon Farre > Cc: tromey@adacore.com, > Simon Farre > Date: Mon, 16 Oct 2023 13:50:26 +0200 > > Adds the StepEndedEvent which signals that one of the thread finite state machines > finished. Matches the behavior of what is generated by MI; the "end stepping range". Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 81264c0cfb3..b2abaa6a2ce 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -11,6 +11,9 @@ > ** New function gdb.notify_mi(NAME, DATA), that emits custom > GDB/MI async notification. > > + ** Added StepEndedEvent which is emitted during stops where it could be determined > + that what triggered the stop was that the stepping state machine finished. > + > *** Changes in GDB 14 This is OK, but please reformat the text so that each line is no longer than 79 columns. > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -3733,6 +3733,9 @@ registry extend @code{gdb.StopEvent}. As a child of > thread when @value{GDBN} is running in non-stop mode. Refer to > @code{gdb.ThreadEvent} above for more details. > > +Emits @code{gdb.StepEndedEvent} that signals that this stop event was generated > +because one of the step-like commands finished. > + > Emits @code{gdb.SignalEvent}, which extends @code{gdb.StopEvent}. Likewise here. Reviewed-By: Eli Zaretskii