From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22405 invoked by alias); 24 Apr 2009 14:06:37 -0000 Received: (qmail 22384 invoked by uid 22791); 24 Apr 2009 14:06:33 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 14:06:26 +0000 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KIL00B00Z0P6K00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Fri, 24 Apr 2009 17:06:24 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.175.232]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIL00C3HZ6KQT00@i-mtaout7.012.net.il>; Fri, 24 Apr 2009 17:06:24 +0300 (IDT) Date: Fri, 24 Apr 2009 14:06:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Do not allow unwinder to terminate inferior in an inferior function call if a C++ exception handler cannot be found. In-reply-to: <49F17924.50300@redhat.com> To: Phil Muldoon Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83vdouf8o2.fsf@gnu.org> References: <49F17924.50300@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00691.txt.bz2 > Date: Fri, 24 Apr 2009 09:32:36 +0100 > From: Phil Muldoon > > + add_setshow_boolean_cmd ("unwind-on-terminating-exception", no_class, > + &unwind_on_terminating_exception_p, _("\ > +Set unwinding of stack if a std::terminate() call originates from\n\ > +the default C++ exception handler."), _("\ > +Show unwinding of stack if a std::terminate() call originates from\n\ > +the default C++ exception handler."), _("\ This is not good: the first sentence of a doc string should not take more than one screen line, because various help commands, such as `apropos', display only the first line. How about Set unwinding of stack if std::terminate is called while in call dummy. ? > +The unwind on terminating exception flag lets the user determine\n\ > +what gdb should do if a std::terminate() call is made from the\n\ > +default exception handler.\n\ > +The default is to unwind the frame."), This doesn't tell what happens if it's set to OFF. > +Similarly, with a C++ program it is possible for the function you Please use C@t{++} (here and elsewhere), it looks better in the printed manual. > +call via the @code{print} or @code{call} command to generate an > +exception that is not handled due to the constraints of the dummy > +frame. I think ``due to the constraints of the dummy frame'' needs an explanation. I'm quite sure many C++ programmers will not immediately grasp the nature of the problem. > +@item set unwind-on-terminating-exception > +@kindex set unwind-on-terminating-exception > +@cindex unwind stack in called functions There is already an index entry with identical text, so please change this one to be more specific to the option you are adding. > +Set unwinding of the stack if a C++ exception is raised but unhandled ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ either exception is raised, but left unhandled or exception is raised, but non handled > If set to off, @value{GDBN} the exception is delivered to > +the default C++ exception handler. This means the debuggee will be terminated, right? If so, we should mention that explicitly. Other than that, the patch for the manual is approved. Thanks.