From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63922-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18653 invoked by alias); 22 May 2009 09:30:52 -0000
Received: (qmail 18629 invoked by uid 22791); 22 May 2009 09:30:49 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 May 2009 09:30:42 +0000
Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KK100900GUTKB00@i_mtaout3.012.net.il> for gdb-patches@sourceware.org; Fri, 22 May 2009 12:30:39 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.115.215]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KK100LSSH326X10@i_mtaout3.012.net.il>; Fri, 22 May 2009 12:30:39 +0300 (IDT)
Date: Fri, 22 May 2009 09:30:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Prec/RFA] fix build error of prec in cygwin
In-reply-to: <daef60380905220206ie125b84k7d6618f2f1e606d0@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83vdnto56l.fsf@gnu.org>
References: <20090518153510.GA23052@ednor.casa.cgf.cx> <20090521152621.GA27524@ednor.casa.cgf.cx> <daef60380905210943n5e089918n2a4b7ade1f917a74@mail.gmail.com> <20090521173804.GA27866@ednor.casa.cgf.cx> <daef60380905211614u2118b66did7cf783ae1b41bb0@mail.gmail.com> <20090522004623.GI28993@ednor.casa.cgf.cx> <daef60380905211912y77feb416o4aeb40d82046d4d1@mail.gmail.com> <20090522041341.GA13509@ednor.casa.cgf.cx> <20090522060545.GA15680@adacore.com> <83ws89occi.fsf@gnu.org> <daef60380905220206ie125b84k7d6618f2f1e606d0@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00485.txt.bz2

> Date: Fri, 22 May 2009 17:06:17 +0800
> From: Hui Zhu <teawater@gmail.com>
> Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
> 
> On Fri, May 22, 2009 at 14:55, Eli Zaretskii <eliz@gnu.org> wrote:
> >> Date: Thu, 21 May 2009 23:05:45 -0700
> >> From: Joel Brobecker <brobecker@adacore.com>
> >>
> >> > "%zu"
> >>
> >> Are we allowed to use %z?
> >
> > No, I don't think so.
> >
> >> I thought that %z is C99
> >
> > It is.
> >
> > I think the best we can do with C90 is use %lu and cast to
> > `unsigned long'.
> >
> I make a new patch use %lu and unsigned long.  Please help me review it.

Looks okay to me, as far as using sizeof in printf-like statements is
concerned.