Re: symbolic debug of loadable modules with kgdb light

Tom Tromey
2009-04-24T15:33:08Z

>>>>> "Caz" == Caz Yokoyama <cazyokoyama@gmail.com> writes:

Caz> I have attached the patch against gdb-6.8.

Thanks.

Caz> - This patch is based on
Caz> http://kgdb.cvs.sourceforge.net/viewvc/kgdb/gdb/. I removed
Caz> garbage as mush as possible. But it still has the code which I
Caz> don't know what it is. I don't remove copyright notice which is
Caz> there.

Do you have copyright assignment papers on file with the FSF? If not,
let me know and I can get you started on the process. This is a
requirement for getting any code into gdb.

Did you write this entire patch yourself? I just want to make sure.
If not, we'll need to get papers from any contributor who wrote more
than 10 lines of code in the patch.

Caz> - I haven't run testsuite because I could not find how to do that while I
Caz> run make in testsuite directory.

"make check". You need dejagnu installed. And you actually have to
run a baseline check without your patch applied, then compare the
results.

Caz> - I believe that the code follows coding standard. Let me know if
Caz> not.

I noticed a number of formatting nits. These are no big deal.

More importantly, the patch makes a bunch of apparently
kernel-debugging-specific changes to generic code. I did not try to
read it very closely, but basically all of these will need to be cleaned
up. Some of the hunks we definitely do not want; e.g., moving
struct value into value.h.

Tom