From: Eli Zaretskii <eliz@gnu.org>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] build id
Date: Tue, 30 Nov 2010 03:50:00 -0000 [thread overview]
Message-ID: <83vd3f8o6k.fsf@gnu.org> (raw)
In-Reply-To: <4CF41FCB.8060103@redhat.com>
> Date: Mon, 29 Nov 2010 16:48:59 -0500
> From: sami wagiaalla <swagiaal@redhat.com>
> CC: gdb-patches@sourceware.org
>
> Thanks for the review :) The attached patch combines the two patches as
> Joel preferred and address the issues Eli brought up. Except for the
> FIXME's. I could not figure out what was meant by the FIXME's so I have
> asked Tromey and Jan for help. Or if anyone else is interested.
>
> Patch Attached.
Thanks.
> +You can also adjust the current verbosity of the @dfn{build id} locating.
You are still using @dfn when you need to reference "build id". I
thought I explained that this wasn't needed.
> +executable. This feature can be turned on or off through the following
^^
Two spaces, please.
The patch for the manual is okay with these changes.
next prev parent reply other threads:[~2010-11-30 3:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 16:28 sami wagiaalla
2010-11-23 19:10 ` Eli Zaretskii
2010-11-29 21:49 ` sami wagiaalla
2010-11-30 3:50 ` Eli Zaretskii [this message]
2010-11-30 16:06 ` sami wagiaalla
2010-11-30 18:12 ` Eli Zaretskii
2010-12-04 19:23 ` Pedro Alves
2010-11-24 18:02 ` Joel Brobecker
2010-11-30 6:07 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vd3f8o6k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox