Re: [patch 4/3] readline-6.2: Substitute inc-hist.texinfo

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 2 May 2011 18:20:14 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> On Mon, 02 May 2011 16:34:51 +0200, Eli Zaretskii wrote:
> > > --- a/readline/doc/hsuser.texi
> > > +++ b/readline/doc/hsuser.texi
> > > @@ -26,9 +26,10 @@ into another language, under the above conditions for modified versions.
> > >  @node Using History Interactively
> > >  @chapter Using History Interactively
> > >  
> > > -@ifclear BashFeatures
> > > -@defcodeindex bt
> > > -@end ifclear
> > > +@c GDB bundling modification:
> > > +@c @ifclear BashFeatures
> > > +@c @defcodeindex bt
> > > +@c @end ifclear
> > 
> > Why do we need to comment this out?
> 
> BTW it was already commented out the same way in readline-5.1.

Yes, I know.  But since we are cleaning up our act, might as well
clean this as well ;-)

> 
> > If BashFeatures is not set, the
> > @defcodeindex line will not be in effect anyway.  Is something setting
> > BashFeatures anywhere when we build our docs?
> 
> You are right BashFeatures is not set but this is @ifclear.

Sorry, I don't know what I was smoking when I wrote that.

But we can't use -DBashFeatures in the makeinfo command line, because
it is really too tied up with Bash.  We need a separate flag.

> >  @ifset HsUser
> >  @pxref{Programming with GNU History, , , history, GNU History Library}.
> >  @end ifset
> >  @ifclear HsUser
> >  @pxref{Programming with GNU History}.
> >  @end ifclear
> > 
> > Then projects that include just hsuser.texi will need to pass the
> > "-DHsUser" switch to makeinfo, while Readline will not.
> > 
> > I'm okay with making these changes for now, to allow people building
> > GDB without failures.  But if Chet accepts the above change, we should
> > switch to it in GDB, so that our doc/Makefile.in is ready for the next
> > upstream release of Readline.
> 
> I guess defined BashFeatures was partially meant for some inclusion, OK.

Yes, it was meant for inclusion in the Bash manual.  The problem is
it mentions Bash explicitly, so it's not good for us.

Go ahead and commit your changes, and I will see how to fix that and
submit the changes to Chet.

Thanks.