From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81038-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23024 invoked by alias); 15 May 2011 17:47:26 -0000
Received: (qmail 23016 invoked by uid 22791); 15 May 2011 17:47:25 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_SV
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 May 2011 17:47:11 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LL800400ZZEH100@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sun, 15 May 2011 20:47:09 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.124.10.122]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LL9004G202J8J50@a-mtaout21.012.net.il>; Sun, 15 May 2011 20:47:09 +0300 (IDT)
Date: Sun, 15 May 2011 17:47:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)
In-reply-to: <CF98DC37D4504926980AE0DDE3FE336F@soleil>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83vcxbeu07.fsf@gnu.org>
References: <CF98DC37D4504926980AE0DDE3FE336F@soleil>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00349.txt.bz2

> From: "Philippe Waroquiers" <philippe.waroquiers@skynet.be>
> Date: Sun, 15 May 2011 19:38:44 +0200
> 
> With the last svn Valgrind, and this patch, the following
> watchpoint will be handled at a reasonable (i.e. "valgrind")
> speed:
> In the program being debugged:
>   char s[1000];
> 
> in gdb:
>   awatch s
> 
> as the hardware watchpoint will be accepted by the valgrind
> gdbserver, and implemented using Valgrind validity bits
> mechanism.

If this is accepted, I think this is NEWS worthy.

A few comments to the documentation part:

> + @item set remote hardware-watchpoint-length-limit @var{limit}
> + Restrict @value{GDBN} to using @var{limit} for the maximum length of
> + remote hardware watchpoints.  A limit of -1, the default, is treated
> + as unlimited.

I think we should tell explicitly that the limit is in bytes.  (Btw,
why the corresponding data types are `int' and not `ssize_t'?)

Also, I think we also document the "show" counterpart of each "set"
command.

Thanks.