From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30992 invoked by alias); 31 Aug 2011 14:46:35 -0000 Received: (qmail 30983 invoked by uid 22791); 31 Aug 2011 14:46:35 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 14:46:19 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LQS00J00RLKOG00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 31 Aug 2011 17:46:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.83.44]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQS00IOCRP3XWO0@a-mtaout20.012.net.il>; Wed, 31 Aug 2011 17:46:16 +0300 (IDT) Date: Wed, 31 Aug 2011 14:46:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event In-reply-to: To: Kevin Pouget Cc: tromey@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83vctdej0n.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00658.txt.bz2 > From: Kevin Pouget > Date: Wed, 31 Aug 2011 16:33:55 +0200 > Cc: gdb-patches@sourceware.org > > The doc was accepted, but I had to reshape the paragraph during the > update, Eli, could you please tell me what you think about it? I have a couple of minor comments: > @defivar ExitedEvent exit_code > -An integer representing the exit code which the inferior has returned. > +An integer representing the exit code which the inferior has returned. ^^^ I think we would be better off without that "has" word. > (Optional, > +will exist only in the case that the inferior exited with some status.) I understand you want to tell that the exit_code attribute is optional? This calls for some rewording, but I actually don't understand how can it be that an inferior doesn't return any exit code at all. AFAIK, the exit code could be random garbage, but it's always there. Can you explain? > +@defivar ExitedEvent inferior > +A reference to the inferior which triggered the exited event. I'd suggest to use @code{exited}, since this is a Python symbol.