From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19073 invoked by alias); 3 Jul 2013 19:22:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19041 invoked by uid 89); 3 Jul 2013 19:22:08 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 19:22:06 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MPD00C00KF7QS00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 03 Jul 2013 22:22:01 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MPD00CL9KGNQL00@a-mtaout20.012.net.il>; Wed, 03 Jul 2013 22:21:59 +0300 (IDT) Date: Wed, 03 Jul 2013 19:22:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 2/2] Add options to skip unavailable locals In-reply-to: <1372816106-15942-3-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83vc4ra1ps.fsf@gnu.org> References: <1372816106-15942-1-git-send-email-yao@codesourcery.com> <1372816106-15942-3-git-send-email-yao@codesourcery.com> X-SW-Source: 2013-07/txt/msg00154.txt.bz2 > From: Yao Qi > Date: Wed, 3 Jul 2013 09:48:26 +0800 > > This is the patch to add new option '--skip-unavailable' to MI > commands '-stack-list-{locals, arguments, variables}'. This patch > extends list_args_or_locals to add a new parameter 'skip_unavailable', > and don't list locals or arguments if values are unavailable and > 'skip_unavailable' is true. Thanks. > + ** The commands -stack-list-locals, -stack-list-arguments and > + -stack-list-variables now accept an optional "--skip-unavailable" > + option. When used, only the available locals or arguments are > + displayed. "optional option" doesn't sound right. I think dropping the "optional" part is all you need. > +If the @code{--skip-unavailable} option is specified, arguments that > +have not been available are not listed. Partially available objects ^^^^^^^^^^^^^^^^^^^^^^^ "are not available". And why "objects" instead of "arguments"? > +If the @code{--skip-unavailable} option is specified, local variables > +that have not been available are not listed. Partially available > +objects are still displayed, however. Likewise, on both accounts. There are other places with the same problems. > +If the @code{--skip-unavailable} option is specified, then, local ^^^^^ This "then" and the comma after it should be deleted. OK with those changes.