From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109466-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10484 invoked by alias); 17 Jan 2014 07:04:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10473 invoked by uid 89); 17 Jan 2014 07:04:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 07:04:23 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MZJ00D00A0KJG00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 17 Jan 2014 09:04:20 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZJ00DIWAB86PA0@a-mtaout22.012.net.il>; Fri, 17 Jan 2014 09:04:20 +0200 (IST)
Date: Fri, 17 Jan 2014 07:04:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/3, doc RFA] gdbserver debug_printf+timestamps: main patch
In-reply-to: <21208.27945.781450.905336@ruffy.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83vbxj143v.fsf@gnu.org>
References: <yjt2zjnztait.fsf@ruffy.mtv.corp.google.com> <52B1842F.5020401@redhat.com> <21205.55987.69477.892571@ruffy.mtv.corp.google.com> <52D81569.3080006@redhat.com> <CADPb22SK=YQeOcOdNPXERxXKOT2E64k=pHhw0GBiLj4LQhL-Ag@mail.gmail.com> <52D82AD5.7000306@redhat.com> <21208.27400.695984.88504@ruffy.mtv.corp.google.com> <21208.27945.781450.905336@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00668.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Thu, 16 Jan 2014 15:37:13 -0800
> cc: gdb-patches <gdb-patches@sourceware.org>
> 
> Doug Evans writes:
>  > v2 is now split into three parts:
>  > 
>  > 1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h
>  > 2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c
>  > 3/3 - the actual debug_printf patch
>  > 
>  > I went with --debug[=timestamp] as the option naming.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,11 @@
>  
>  *** Changes since GDB 7.7
>  
> +* New features in the GDB remote stub, GDBserver
> +
> +  ** GDBserver now takes an optional argument to --debug, --debug=timestamp,
> +     that adds a timestamp with each debugging message.
             ^^^^^^^^^^^^^^^^^^^^^
Either "adds to" or "prints with" or "includes with".

The documentation parts are OK with that change.