From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, sivachandra@google.com
Subject: Re: [PATCH] [PR python/18285] Fix.
Date: Fri, 24 Apr 2015 20:22:00 -0000 [thread overview]
Message-ID: <83vbglxonc.fsf@gnu.org> (raw)
In-Reply-To: <yjt2iocluxxc.fsf@ruffy.mtv.corp.google.com>
> From: Doug Evans <dje@google.com>
> cc: sivachandra@google.com
> Date: Fri, 24 Apr 2015 12:30:07 -0700
>
> This patch fixes pr 18285 by adding a new get_result_type method
> to xmethod workers. This way we can fetch the result type without
> having to call the xmethod (which is important for ptype where
> we have EVAL_AVOID_SIDE_EFFECTS).
>
> Regression tested on amd64-linux.
>
> 2015-04-24 Doug Evans <dje@google.com>
>
> PR python/18285
> * NEWS: Document new gdb.XMethodWorker.get_result_type method.
> * eval.c (evaluate_subexp_standard) <OP_FUNCALL>: Handle
> EVAL_AVOID_SIDE_EFFECTS for xmethods.
> * extension-priv.h (struct extension_language_ops)
> <get_xmethod_result_type>: New member.
> * extension.c (get_xmethod_result_type): New function.
> * extension.h (get_xmethod_result_type): Declare.
> * python/py-xmethods.c (get_result_type_method_name): New static
> global.
> (py_get_result_type_method_name): Ditto.
> (gdbpy_get_xmethod_result_type): New function.
> (gdbpy_initialize_xmethods): Initialize py_get_result_type_method_name.
> * python/python-internal.h (gdbpy_get_xmethod_result_type): Declare.
> * python/python.c (python_extension_ops): Add
> gdbpy_get_xmethod_result_type.
> * valarith.c (value_x_binop): Handle EVAL_AVOID_SIDE_EFFECTS for
> xmethods.
> (value_x_unop): Ditto.
> * value.c (result_type_of_xmethod): New function.
> * value.h (result_type_of_xmethod): Declare.
>
> testsuite/
> * gdb.python/py-xmethods.exp: Add ptype tests.
> * gdb.python/py-xmethods.py (E_method_char_worker): Add
> get_result_type method.
>
> doc/
> * python.texi (Xmethod API) <gdb.XMethodWorker.get_result_type>:
> Document.
> (Writing an Xmethod): Add get_result_type to example.
The documentation parts are okay. Thanks.
next prev parent reply other threads:[~2015-04-24 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 19:30 Doug Evans
2015-04-24 20:22 ` Eli Zaretskii [this message]
2015-04-30 0:11 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vbglxonc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox