From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36519 invoked by alias); 22 May 2015 12:30:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36509 invoked by uid 89); 22 May 2015 12:30:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 May 2015 12:30:05 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NOR00F003WDY900@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 22 May 2015 15:30:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOR00F16422HM80@a-mtaout22.012.net.il>; Fri, 22 May 2015 15:30:02 +0300 (IDT) Date: Fri, 22 May 2015 12:30:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE In-reply-to: <1432293831-23599-1-git-send-email-patrick@parcs.ath.cx> To: Patrick Palka Cc: gdb-patches@sourceware.org, patrick@parcs.ath.cx Reply-to: Eli Zaretskii Message-id: <83vbfk4wxi.fsf@gnu.org> References: <1432293831-23599-1-git-send-email-patrick@parcs.ath.cx> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00608.txt.bz2 > From: Patrick Palka > Cc: Patrick Palka > Date: Fri, 22 May 2015 07:23:50 -0400 > > The HISTSIZE environment variable is generally expected to be read by > shells, not by applications. Some distros for example globally export > HISTSIZE in /etc/profile -- with the intention that it only affects > shells -- and by doing so it renders useless GDB's own mechanism for > setting the history size via .gdbinit. Also, annoyances may arise when > HISTSIZE is not interpreted the same way by the shell and by GDB, e.g. > PR gdb/16999. That can always be fixed on a shell-by-shell basis but it > may be impossible to be consistent with the behavior of all shells at > once. Finally it just makes sense to not confound shell environment > variables with application environment variables. > > gdb/ChangeLog: > > * NEWS: Add entry. > * top.c (init_history): Read from GDBHISTSIZE instead of > HISTSIZE. > (init_main): Refer to GDBHISTSIZE instead of HISTSIZE. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Command History): Replace occurrences of HISTSIZE > with GDBHISTSIZE. Thanks. I think we should explain in the manual why we don't use HISTSIZE. And I wonder why we cannot use HISTSIZE if neither GDBHISTSIZE nor .gdbinit specify the size, but you probably already discussed that. Otherwise, the documentation part is OK.