From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: kevinb@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle
Date: Fri, 05 May 2017 06:25:00 -0000 [thread overview]
Message-ID: <83vapfg73m.fsf@gnu.org> (raw)
In-Reply-To: <d0448ba9b954ef3cba07228d3b6c71ed@polymtl.ca> (message from Simon Marchi on Fri, 05 May 2017 00:01:31 -0400)
> Date: Fri, 05 May 2017 00:01:31 -0400
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org, eliz@gnu.org
>
> > +@defun gdb.thread_from_thread_handle (thread_handle)
> > +Return the thread object corresponding to the thread handle,
> > +@var{thread_handle}, a thread library specific data structure such as
>
> The comma before @var{thread_handle} feels unnecessary. And I think you
> could shorten it to "... corresponding to @var{thread_handle}, ..."
> without loss of clarity.
Both variants are OK.
> Eli, do you have something to say about this patch?
Sorry, I missed it at the time. It's fine with me.
Thanks.
next prev parent reply other threads:[~2017-05-05 6:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 5:50 [PATCH v2 0/7] Thread handle to thread info mapping Kevin Buettner
2017-04-09 6:06 ` [PATCH v2 1/7] Add target method for converting thread handle to thread_info struct pointer Kevin Buettner
2017-05-05 3:26 ` Simon Marchi
2017-07-19 0:01 ` Kevin Buettner
2017-04-09 6:07 ` [PATCH v2 6/7] Add thread_handle_to_thread_info support for remote targets Kevin Buettner
2017-05-06 2:28 ` Simon Marchi
2017-04-09 6:07 ` [PATCH v2 5/7] Add thread_db_notice_clone to gdbserver Kevin Buettner
2017-05-06 1:46 ` Simon Marchi
2017-04-09 6:07 ` [PATCH v2 2/7] Add `thread_from_thread_handle' function to (Python) gdb module Kevin Buettner
2017-04-13 16:11 ` Phil Muldoon
2017-05-05 3:54 ` Simon Marchi
2017-04-09 6:07 ` [PATCH v2 4/7] Test case for gdb.thread_from_thread_handle Kevin Buettner
2017-05-05 5:19 ` Simon Marchi
2017-04-09 6:07 ` [PATCH v2 7/7] Documentation for qXfer:threads:read handle attribute Kevin Buettner
2017-04-09 8:09 ` Eli Zaretskii
2017-04-09 6:07 ` [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle Kevin Buettner
2017-05-05 4:01 ` Simon Marchi
2017-05-05 6:25 ` Eli Zaretskii [this message]
2017-07-19 0:13 ` Kevin Buettner
2017-04-20 0:19 ` [PATCH v2 0/7] Thread handle to thread info mapping Kevin Buettner
2017-04-26 17:46 ` Kevin Buettner
2017-05-03 18:32 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vapfg73m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox