From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122246 invoked by alias); 19 May 2017 11:17:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122220 invoked by uid 89); 19 May 2017 11:17:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 11:17:14 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBfuC-00081K-38 for gdb-patches@sourceware.org; Fri, 19 May 2017 07:17:16 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBfuB-00081G-Vl; Fri, 19 May 2017 07:17:12 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3439 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBfuA-0004lO-Vs; Fri, 19 May 2017 07:17:11 -0400 Date: Fri, 19 May 2017 11:17:00 -0000 Message-Id: <83vaox2j0w.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org In-reply-to: (message from Pedro Alves on Fri, 19 May 2017 10:48:57 +0100) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <20170504194442.63AAF60B72@joel.gnat.com> <83o9v3cs25.fsf@gnu.org> <91d9fc6cc7c07674a0b5cd02e7b1502b@polymtl.ca> <8360h38r1r.fsf@gnu.org> <20170517143136.mdnstf2u2jiydvnd@adacore.com> <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00436.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 19 May 2017 10:48:57 +0100 > > On 05/19/2017 10:10 AM, Eli Zaretskii wrote: > >> Date: Wed, 17 May 2017 19:01:23 +0300 > >> From: Eli Zaretskii > >> CC: simon.marchi@polymtl.ca, gdb-patches@sourceware.org > >> > >> I will probably post later a workaround patch for older versions, > >> but that's for master. I see no reason to delay the release or to > >> have the fix on the branch. > > > > Is the below OK? It's a bit ugly, and a small fix is needed even for > > the latest MinGW runtime. > > Messing with libstdc++ internal macros and changing what libstdc++ > defines is recipe for undefined behavior and trouble. I'd prefer > avoiding it if possible. > > How about going back to the original gdb::to_string, implemented > in terms of stringstring: > > https://sourceware.org/ml/gdb-patches/2016-10/msg00535.html > > ... with a tweak to only use if it the host compiler doesn't support > std::to_string, like the patchlet below. Fine with me, but Someone(TM) should figure out what to use instead of "#if 0".