Re: [python] Allow explicit locations in breakpoints.

Simon Marchi
2017-10-16T18:31:15Z

> diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp
> index bd138ac3d2..228489f74e 100644
> --- a/gdb/testsuite/gdb.python/py-breakpoint.exp
> +++ b/gdb/testsuite/gdb.python/py-breakpoint.exp
> @@ -547,6 +547,72 @@ proc test_bkpt_events {} {
> check_last_event breakpoint_deleted
> }
>
> +proc test_bkpt_explicit_loc {} {
> + global srcfile testfile
> +
> + with_test_prefix test_bkpt_invisible {

This should be test_bkpt_explicit_loc. But I think I'll do a pass
and make all these procs use "proc_with_prefix", to avoid having to
repeat the proc name.

> + # Start with a fresh gdb.
> + clean_restart ${testfile}
> +
> + if ![runto_main] then {
> + fail "cannot run to main."
> + return 0
> + }
> +
> + delete_breakpoints
> +
> + set bp_location1 [gdb_get_line_number "Break at multiply."]
> + set bp_location2 [gdb_get_line_number "Break at add."]
> +
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li $bp_location1\")" \
> + "Set explicit breakpoint by line" 0> + gdb_continue_to_breakpoint "Break at multiply" \
> + ".*Break at multiply.*"
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li +1\")" \
> + "Set explicit breakpoint by relative line" 0
> + gdb_continue_to_breakpoint "Break at add" \
> + ".*Break at add.*"
> + delete_breakpoints
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li -1\")" \
> + "Set explicit breakpoint by relative negative line" 0
> + gdb_continue_to_breakpoint "Break at multiply" \
> + ".*Break at multiply.*"
> + delete_breakpoints
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-function add\")" \
> + "Set explicit breakpoint by function" 0
> + gdb_continue_to_breakpoint "Break at function add" \
> + ".*Break at function add.*"
> + delete_breakpoints
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-source $srcfile -function add\")" \
> + "Set explicit breakpoint by source file and function" 0
> + gdb_continue_to_breakpoint "Break at function add" \
> + ".*Break at function add.*"
> + delete_breakpoints
> + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-source $srcfile -li $bp_location2\")" \
> + "Set explicit breakpoint by source file and line number" 0
> + gdb_continue_to_breakpoint "Break at add" \
> + ".*Break at add.*"
> + delete_breakpoints
> + gdb_test "python bp1 = gdb.Breakpoint (\"-source $srcfile\")" \
> + "RuntimeError: Source filename requires function, label, or line offset.*" \
> + "Set invalid explicit breakpoint by source only"
> + # The below will print a warning but set pending breakpoints.
> + gdb_test "python bp1 = gdb.Breakpoint (\"-source foo.c -li 5\")" \
> + "No source file named foo.*" \
> + "Set invalid explicit breakpoint by missing source and line"
> + gdb_test "python bp1 = gdb.Breakpoint (\"-source $srcfile -li 900\")" \
> + "No line 900 in file \"$srcfile\".*" \
> + "Set invalid explicit breakpoint by source and invalid line."
> + gdb_test "python bp1 = gdb.Breakpoint (\"-function blah\")" \
> + "Function \"blah\" not defined.*" \
> + "Set invalid explicit breakpoint by missing function."
> + # Invalid explicit location flags.
> + gdb_test "python bp1 = gdb.Breakpoint (\"-foo -li 5\")" \
> + "RuntimeError: invalid explicit location argument, \"-foo\".*" \
> + "Set invalid explicit breakpoint by wrong flag"

For readability, could you add some empty lines between the logical blocks above?

> + }
> +}
> +
> test_bkpt_basic
> test_bkpt_deletion
> test_bkpt_cond_and_cmds
> @@ -558,3 +624,4 @@ test_bkpt_temporary
> test_bkpt_address
> test_bkpt_pending
> test_bkpt_events
> +test_bkpt_explicit_loc
>

Simon