From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61580 invoked by alias); 17 Nov 2017 13:31:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61237 invoked by uid 89); 17 Nov 2017 13:31:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Phil, H*r:4.82, H*r:134, HTo:U*pmuldoon X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 13:31:18 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFgjh-00025t-Dy for gdb-patches@sourceware.org; Fri, 17 Nov 2017 08:31:16 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFgjh-00025p-Aa; Fri, 17 Nov 2017 08:31:13 -0500 Received: from [176.228.60.248] (port=2915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eFgjf-0002ud-F6; Fri, 17 Nov 2017 08:31:13 -0500 Date: Fri, 17 Nov 2017 13:31:00 -0000 Message-Id: <83vai9ghh5.fsf@gnu.org> From: Eli Zaretskii To: Phil Muldoon CC: simon.marchi@ericsson.com, keiths@redhat.com, gdb-patches@sourceware.org In-reply-to: (message from Phil Muldoon on Fri, 17 Nov 2017 11:02:08 +0000) Subject: Re: [python] Allow explicit locations in breakpoints. Reply-to: Eli Zaretskii References: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> <58311250-9ab1-39d1-99b6-07478bc8c2ab@redhat.com> <4768c7ad-cc3d-5702-fa93-40e9760d4ee8@ericsson.com> <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> <31ad8fb7-0e20-13a5-45d1-c9fa67b76e27@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00336.txt.bz2 > From: Phil Muldoon > Date: Fri, 17 Nov 2017 11:02:08 +0000 > > I just realised this needs a doc review also. Doc review coming up. > diff --git a/gdb/NEWS b/gdb/NEWS > index 9246659bfb..592fe70156 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -24,6 +24,9 @@ > gdb.new_thread are emitted. See the manual for further > description of these. > > + ** Python breakpoints can now accept explicit locations. See the > + manual for a further description of this feature. I think "a further" should lose the "a" part. Also, how about mentioning the node name in the manual where this is described? > +watchpoint. The contents can be any location recognized by the ^^ Two spaces here, please. > +@code{break} command or, in the case of a watchpoint, by the > +@code{watch} command. Alternatively, create a new a explicit location ^^^^^^^^^^^^^^^^^^^^^^^ The second "a" should be deleted. > +@var{function}, @var{label} and @var{line}. The optional @var{type} > +denotes the breakpoint to create from the types defined later in this > +chapter. This argument can be either @code{gdb.BP_BREAKPOINT} or I think "denotes the breakpoint to create from the types" is at least confusing. What did you mean here? > +@code{gdb.BP_WATCHPOINT}; it defaults to @code{gdb.BP_BREAKPOINT}. > +The optional @var{internal} argument allows the breakpoint to become > +invisible to the user. The breakpoint will neither be reported when ^ I think you want a colon here, not a period, because the next sentence explains what does it mean for a breakpoint to be "invisible". Alternatively, start the next sentence with "Invisible breakpoints will neither be reported ...". > +created, nor will it be listed in the output from @code{info > +breakpoints} (but will be listed with the @code{maint info ^^^^ "by", I think, not "with". > +breakpoints} command). The optional @var{temporary} argument makes > +the breakpoint a temporary breakpoint. Temporary breakpoints are > +deleted after they have been hit. Any further access to the Python > +breakpoint after it has been hit will result in a runtime error (as I think you want to say "to the temporary breakpoint" here. The fact that it is a Python breakpoint is not really relevant. > +that breakpoint has now been automatically deleted). The optional > +@var{wp_class} argument defines the class of watchpoint to create, if > +@var{type} is @code{gdb.BP_WATCHPOINT}. If a watchpoint class is not > +provided, it is assumed to be a @code{gdb.WP_WRITE} class. What are the other supported classes? Either state that here or point to where that is described. Thanks.