From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] doc: Add table of MI versions
Date: Tue, 15 Jan 2019 19:20:00 -0000 [thread overview]
Message-ID: <83va2pd8yv.fsf@gnu.org> (raw)
In-Reply-To: <f67c6a9ddf9a9d3dea6c4f6989d1469f@polymtl.ca> (message from Simon Marchi on Tue, 15 Jan 2019 13:27:37 -0500)
> Date: Tue, 15 Jan 2019 13:27:37 -0500
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
>
> >> -Although @sc{gdb/mi} is still incomplete, it is currently being used
> >> -by a variety of front ends to @value{GDBN}. This makes it difficult
> >> -to introduce new functionality without breaking existing usage. This
> >> -section tries to minimize the problems by describing how the protocol
> >> -might change.
> >> +The MI interface is versioned, allowing it to evolve while avoiding
> >> breaking
> >> +existing front ends.
> >
> > Some of the rationale you removed sounds like something good to have.
> > Explaining the rationale for a section is in general a Good Thing,
> > IMO.
>
> The "is still incomplete" sentence sounds useless to me, and can even
> make people wonder if they should really use it, since it's incomplete.
> It will always evolve, it will never be "complete". I could add back
> the last sentence with a bit more stuff, like so:
>
> The MI interface is versioned, allowing it to evolve while avoiding
> breaking existing front ends. This section describes how the protocol
> might change within a version and the breaking changes across versions.
The part about MI being incomplete is not what I wanted to preserve.
How about something like this:
Since @sc{gdb/mi} is used by a variety of front ends to
@value{GDBN}, introduction of new MI functionality almost always
breaks existing usage. This section describes how the protocol
changes and how to request previous version of the protocol when it
does.
> >> If the changes are likely to break front ends, the MI version level
> >> -will be increased by one. This will allow the front end to parse the
> >> -output according to the MI version. Apart from mi0, new versions of
> >> -@value{GDBN} will not support old versions of MI and it will be the
> >> -responsibility of the front end to work with the new one.
> >> +will be increased by one. Previous versions of MI remain available,
> >> allowing
> >> +front ends to keep using them until they are modified to use the
> >> latest MI
> >> +version.
> >
> > Likewise here: the old text explained that miN version will generally
> > be incompatible with miN-1 version. Your change removes that
> > important statement. I'd prefer not to lose that part.
>
> Which part of the original text says that?
This one:
[...] new versions of @value{GDBN} will not support old versions of
MI.
Which is actually slightly confusing; a better way of saying that is
something like
new versions of the MI protocol are not compatible with the old
versions
> What I want to say is that even if a new version of MI is
> released, the previous versions of MI stay available for some time,
> allowing front ends to do the transition.
That's okay, but it's a separate issue. Let's keep the other
information as well, as suggested above.
> >> -@c Starting with mi3, add a new command -mi-version that prints the
> >> MI
> >> -@c version?
> >
> > Why did you remove the comment? It seems like a valid idea, perhaps
> > worth implementing.
>
> I don't think this is the right place for such things (it's quite
> hidden). If we really want to keep track of this, let's open an issue
> on Bugzilla for it.
I'm fine with moving this to bugzilla, I just don't want to lose the
suggestion altogether, as part of unrelated changes on top of that.
> About the idea itself, I don't think we need to implement this.
We don't need to agree with it, we just need to preserve the
suggestion.
> If front ends request a specific version of MI (which is good
> practice, in my experience), they won't need to query it.
What if a front end can support several versions, provided that it
knows the latest version which is provided? Why require such a front
end to request the lowest common denominator, instead of adapting to
the latest version it can support?
Thanks.
next prev parent reply other threads:[~2019-01-15 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:39 Simon Marchi
2019-01-15 17:28 ` Eli Zaretskii
2019-01-15 18:27 ` Simon Marchi
2019-01-15 19:20 ` Eli Zaretskii [this message]
2019-01-15 20:37 ` Simon Marchi
2019-01-16 17:04 ` Eli Zaretskii
2019-01-16 17:21 ` Simon Marchi
2019-01-16 20:57 ` André Pönitz
2019-01-16 19:35 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83va2pd8yv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox