From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90511 invoked by alias); 4 Mar 2019 15:57:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90489 invoked by uid 89); 4 Mar 2019 15:57:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 15:57:03 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0pxd-0006NR-7d; Mon, 04 Mar 2019 10:57:01 -0500 Received: from [176.228.60.248] (port=4237 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h0pxc-0002NG-Ry; Mon, 04 Mar 2019 10:57:01 -0500 Date: Mon, 04 Mar 2019 15:57:00 -0000 Message-Id: <83va0yeipj.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <878sxuad8g.fsf@tromey.com> (message from Tom Tromey on Mon, 04 Mar 2019 08:08:47 -0700) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83ef7oezh0.fsf@gnu.org> <878sxuad8g.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00033.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Mon, 04 Mar 2019 08:08:47 -0700 > > Eli> + if (fg.is_none ()) > Eli> + fgcolor = norm_attr & 15; > Eli> + else > Eli> + fgcolor = fg_color[fg.get_value () & 15]; > > get_value is only defined for basic colors; you'll get an assertion here > if the color is not basic. For non-basic colors, you can get the rgb > values for the color instead via the get_rgb method. I've seen the assertion in the code, but it wasn't clear to me when/if I could get non-basic colors on MS-Windows. Could you describe a situation where that could happen? Thanks.