From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36252 invoked by alias); 17 Mar 2019 15:57:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36243 invoked by uid 89); 17 Mar 2019 15:57:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_50,SPF_PASS autolearn=ham version=3.3.1 spammy=themes, TUIs, tui's, TUI's X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 15:57:36 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5YAI-0007cl-Pk; Sun, 17 Mar 2019 11:57:35 -0400 Received: from [176.228.60.248] (port=2919 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5YAH-0001TB-Kr; Sun, 17 Mar 2019 11:57:34 -0400 Date: Sun, 17 Mar 2019 15:57:00 -0000 Message-Id: <83va0hwl24.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org, tom@tromey.com In-reply-to: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> (message from Pedro Alves on Thu, 14 Mar 2019 17:35:57 +0000) Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight References: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00345.txt.bz2 > From: Pedro Alves > Date: Thu, 14 Mar 2019 17:35:57 +0000 > > This patch changes that to something that I find much more sensible -- > only reverse the default foreground/background colors, leave styled > text colors alone. If the foreground color is not the default (because the > text was styled), leave the foreground color as is. If > e.g., the terminal is fg=BLACK, and bg=WHITE, and the style wants to > print text in RED, reverse the background color (print in BLACK), but > still print the text in RED. > > I've attached screenshots of before/after patch, with both > white-on-black (actually, linux-colors / grey-ish-on-black), > and black-on-white themes in my console (konsole). Also attached > screenshots with styling disabled, so that you can see how the > after-patch versions look more like the unstyled output. > > Note: The new ui_file_style::set_fg method isn't called set_foreground > instead, because set_foreground is a macro in /usr/lib/term.h (ncurses). > > WDYT? > > Eli, could you try this on Windows, see if it behaves as intended there? Tested on MS-Windows, works fine. I think you should push this. Thanks.