From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2ATyHN2vbF+yfgAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 10:40:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 747691EE05; Thu, 24 Sep 2020 10:40:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B7541E509 for ; Thu, 24 Sep 2020 10:40:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A670386F435; Thu, 24 Sep 2020 14:40:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A670386F435 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600958428; bh=VyawFuNzv+pNjGEsL4OdltzOMxhL5LkVRhjgFawSCAo=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hk/xX+LUS2gzLroj/6Ol/P/FWo/kVFHdQJjnu4jtZZWJsleSDg+RpPqqz8bdWYtZl OR+JID78yVrxDn+I2IT0lwEGMGvtNGFQmVOmMCRt0R4IturfcCSU53VF4Gi+IKN9Sx xuYtnnEhkJdUAZyqGYMS5tlPndVsh9lQT1a/ywqg= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 007CB386F403 for ; Thu, 24 Sep 2020 14:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 007CB386F403 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34147) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLSQ4-0005ki-UR; Thu, 24 Sep 2020 10:40:24 -0400 Received: from [176.228.60.248] (port=2769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLSQ3-0005yu-4c; Thu, 24 Sep 2020 10:40:24 -0400 Date: Thu, 24 Sep 2020 17:40:32 +0300 Message-Id: <83v9g3tezj.fsf@gnu.org> To: Simon Marchi In-Reply-To: (message from Simon Marchi on Wed, 23 Sep 2020 23:35:10 -0400) Subject: Re: [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent References: <20200923172122.2089-1-ssbssa@yahoo.de> <20200923172122.2089-3-ssbssa@yahoo.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Simon Marchi > Date: Wed, 23 Sep 2020 23:35:10 -0400 > > On 2020-09-23 1:21 p.m., Hannes Domani via Gdb-patches wrote: > > GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created > > in the target process (like if the target doesn't have a console). > > > > Since this prevents DebugBreakProcess from being called (which should > > always work), this removes it. > > Eli, does that make sense to you? Just judging from the explanation > above, it sounds fine to me. The explanation sounds fine, but I don't know enough about the details to say something intelligent. This seems to have some non-trivial context that I lack to understand, for example, why the fact that "GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created in the target process" is a problem. But it's okay to disregard my ignorance and go ahead with pushing this.