From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RB6PKg2hcmDAaQAAWB0awg (envelope-from ) for ; Sun, 11 Apr 2021 03:11:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 67CC11EF4F; Sun, 11 Apr 2021 03:11:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B8111E54D for ; Sun, 11 Apr 2021 03:11:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDDBA389040B; Sun, 11 Apr 2021 07:11:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDDBA389040B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618125067; bh=J6TAeshuMu/A1Jrc7X/fFy5rZ/+jgZv5CtD8UsqMbFE=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OcUzryy33eW90y4UsAl88QcsqZZpLK8ZQBCGVfO+rqNhh1hVo5NHirQTcq86QTa1J odg9vL/XtGzl7li0ttKGaknSzTXE96dm+tPfmcizHTGtMjxkIFn24/2WaDZy9FYsA4 1A2+XMaaHnpLlqSkQk8TdG6AnYNusmNtvfWgU5ms= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id EF2F53857C74 for ; Sun, 11 Apr 2021 07:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF2F53857C74 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58118) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVUFK-0008Uo-LP; Sun, 11 Apr 2021 03:11:05 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVUFJ-0001Cb-TC; Sun, 11 Apr 2021 03:11:02 -0400 Date: Sun, 11 Apr 2021 10:10:43 +0300 Message-Id: <83v98t47po.fsf@gnu.org> To: Simon Marchi In-Reply-To: <91c6b291-f9f3-0ee9-1ef1-31ba6bb65326@polymtl.ca> (message from Simon Marchi on Sat, 10 Apr 2021 18:56:05 -0400) Subject: Re: Subtle problems with "info sharedlibrary" on MS-Windows References: <83czw7p4nd.fsf@gnu.org> <777379173.1335754.1615393830518@mail.yahoo.com> <83mtvbne96.fsf@gnu.org> <259022839.1083386.1615397702855@mail.yahoo.com> <83y2dwbow6.fsf@gnu.org> <83lf9vbljw.fsf@gnu.org> <87sg3ygp1d.fsf@tromey.com> <834kge57z0.fsf@gnu.org> <91c6b291-f9f3-0ee9-1ef1-31ba6bb65326@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Cc: gdb-patches@sourceware.org > From: Simon Marchi > Date: Sat, 10 Apr 2021 18:56:05 -0400 > > > --- gdbserver/win32-low.cc~ 2021-03-25 03:47:10.000000000 +0200 > > +++ gdbserver/win32-low.cc 2021-04-10 21:05:48.677425000 +0300 > > @@ -1165,11 +1165,13 @@ load_psapi (void) > > > > #ifndef _WIN32_WCE > > I see that this patch deals with _WIN32_WCE. We removed support for > WinCE in 84b300de3666 ("gdbserver: remove support for ARM/WinCE"). It > looks like I failed to remove the WinCE-related core from win32-low.cc > (I guess I didn't know about the _WIN32_WCE macro then). Would you mind > if we first removed that unncecessary code first? That would make your > patch simpler. I'd actually prefer it the other way around, for 2 reasons: (a) the patch for windows-nat.c is already in, so it would make sense to fix gdbserver ASAP; (b) I built with the patch a recent snapshot of master where these conditions are still present, and I would like to avoid the need to build yet another snapshot just for this small change.