From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hjKEKAP7hmCRagAAWB0awg (envelope-from ) for ; Mon, 26 Apr 2021 13:40:19 -0400 Received: by simark.ca (Postfix, from userid 112) id 958591F11C; Mon, 26 Apr 2021 13:40:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB0A61E54D for ; Mon, 26 Apr 2021 13:40:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 223A93892451; Mon, 26 Apr 2021 17:40:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 223A93892451 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619458818; bh=0VsR/5/QmI8kppvYlLMSwSawif2txxKGBtkpVH5aRbY=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UL4+Y4X3vlJksKzg2pdN6cfstAb16wHZKbYVW9C/SmGHu2wQvgedsIWNqwsOMXmku j6lOWy1Kawp3tnXb7xax5qPcmspIy7kM6+DDnR85WxroJfXbUB8z0dvoY+MEnG227S vRL1MX3qvF6Il6fACvAXpNQOObzTfP1OSgWz5jaU= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0DB1E3892451 for ; Mon, 26 Apr 2021 17:40:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DB1E3892451 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33421) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb5DQ-0004k2-Gw; Mon, 26 Apr 2021 13:40:14 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4704 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lb5DL-0007Zt-EM; Mon, 26 Apr 2021 13:40:11 -0400 Date: Mon, 26 Apr 2021 20:39:47 +0300 Message-Id: <83v989hrmk.fsf@gnu.org> To: Andrew Burgess In-Reply-To: (message from Andrew Burgess on Mon, 26 Apr 2021 18:07:03 +0100) Subject: Re: [PATCH 4/4] gdb/mi: extend -file-list-exec-source-files command References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Mon, 26 Apr 2021 18:07:03 +0100 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -31,6 +31,17 @@ > equivalent of the CLI's "break -qualified" and "dprintf > -qualified". > > + ** '-file-list-exec-source-files' can now accept a regular > + expression for filtering, and accepts the flags --dirname, > + --basename and --group-by-binary, making this command equivalent > + of the cli 'info sources' command. > + > + In the non '--group-by-binary' mode an extra field > + 'debug-fully-read' has been added to each source file tuple to > + indicate if the debug information for the compilation unit > + containing this source file has been fully read or not, the > + values for this field are 'true' or 'false'. This part is OK. > +With no arguments this command returns a list of source files. Each > +source file is represented by a tuple with the fields; @var{file}, > +@var{fullname}, and @var{debug-fully-read}. The @var{file} is the > +display name for the file, while @var{fullname} is the absolute path > +to the file. ^^^^^^^^^^^^^ ^^^^^^^^^^^ GNU Coding Standards frown on calling "path" anything that is not a PATH-style directory list. Please use "absolute name of the file" instead. > The @var{fullname} field can be elided if the absolute > +path to the source file can't be computed. Likewise. > +If @code{--dirname} is provided then @var{regexp} is matched only > +against the directory name of each source file. If @code{--basename} > +is provided then @var{regexp} is matched against the source files > +basename. ^^^^^^^^ "basenames", in plural. > +If @code{--group-by-binary} is used then the format of the results is > +changed. The results will now be a list of tuples, with each tuple > +representing an object file (executable or shared libraries) loaded > +into @value{GDBN}. The fields of these tuples are; @var{filename}, > +@var{debug-fully-read}, and @var{sources}. The @var{filename} is the > +absolute path to the object file, @var{debug-fully-read} is a string, ^^^^^^^^^^^^^ "path" again Thanks.