From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G1FcH6DJ6mL5DiAAWB0awg (envelope-from ) for ; Wed, 03 Aug 2022 15:16:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 70F561EA05; Wed, 3 Aug 2022 15:16:48 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xhkJnktr; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 918251E9ED for ; Wed, 3 Aug 2022 15:16:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 27A3C3858038 for ; Wed, 3 Aug 2022 19:16:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27A3C3858038 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659554207; bh=9GxAJD1c33qcpoMWt9SJawjeUFXVjoCvTTmOE+nTQNw=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xhkJnktrk16Fv+e7+EqC+SvXp1g2vJ9EgiwA3K3ognvAbX5BAjdgqzrzRcmXR2wHE sAULtZKnnUa8VEoxvn32dg55wVwyXHtDYm0WHjFR5WLMAwBWagTH5D5ILNfaDp54fy e/YwoEMO07ws5MK3W32SuRiSyKv89Q2UP1d8qZLk= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 778893858C39 for ; Wed, 3 Aug 2022 19:16:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 778893858C39 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJJr0-00047a-C6; Wed, 03 Aug 2022 15:16:26 -0400 Received: from [87.69.77.57] (port=2877 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJJqz-0004yo-K7; Wed, 03 Aug 2022 15:16:26 -0400 Date: Wed, 03 Aug 2022 22:16:21 +0300 Message-Id: <83v8r93zp6.fsf@gnu.org> To: Tom Tromey In-Reply-To: <87les5go5f.fsf@tromey.com> (message from Tom Tromey on Wed, 03 Aug 2022 12:47:24 -0600) Subject: Re: [PATCH 1/2] Move some Windows operations to worker thread References: <20220803130822.735057-1-tromey@adacore.com> <20220803130822.735057-2-tromey@adacore.com> <83a68l5u4h.fsf@gnu.org> <87les5go5f.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Wed, 03 Aug 2022 12:47:24 -0600 > > >> + HANDLE bg_thread = CreateThread (nullptr, 0, fn, this, 0, nullptr); > > Eli> That zero in the 2nd argument of CreateThread means the worker thread > Eli> will get the same stack size as the value recorded in the GDB > Eli> executable file's header, which is 12MB according to my reading of > Eli> gdb/Makefile, at least in my build? That's unlikely to be required > Eli> for this thread, so I suggest to specify a non-zero value there > Eli> instead. I guess 64KB should be enough? > > I changed it to `64 * 1024` and re-tested, and this worked ok. Thanks.