From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10596 invoked by alias); 13 Jan 2010 21:04:52 -0000 Received: (qmail 10358 invoked by uid 22791); 13 Jan 2010 21:04:51 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jan 2010 21:04:45 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KW700J00EERM700@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 13 Jan 2010 23:03:59 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.60.183]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KW700HO2EIMXG50@a-mtaout22.012.net.il>; Wed, 13 Jan 2010 23:03:59 +0200 (IST) Date: Wed, 13 Jan 2010 21:04:00 -0000 From: Eli Zaretskii Subject: Re: Multiexec MI In-reply-to: <201001132329.30212.vladimir@codesourcery.com> To: Vladimir Prus Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83tyup7m3d.fsf@gnu.org> References: <201001132329.30212.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00363.txt.bz2 > From: Vladimir Prus > Date: Wed, 13 Jan 2010 23:29:30 +0300 > > This patch implements MI support for multiexec. I attach my notes on design, as well > as patch. The patch also contains documentation updates. Thanks. I have a few comments about the docs. > -@item =thread-group-created,id="@var{id}" > +@item =thread-group-added,id="@var{id}" > +@itemx =thread-group-removed,id="@var{id}" > +A thread thread group was either added or removed. The @var{id} field ^^^^^^^^^^^^^ I believe one of these two "thread"s should be removed. > +@item =thread-group-started,id="@var{id}",pid="@var{pid}" > +A thread group either because associated with a running program, > +either because the program was started or it the thread group > +was attached to a program. Something is wrong with this sentence. > +A thread thread group is no longer associated with a running program, ^^^^^^^^^^^^^ Another redundant "thread". > +library are loaded. The @var{thread-group} field, if present, > +contains the id of the thread group in which the library was loaded. > +If the field is absent, it means the library was loaded in all present > +thread groups. "Library loaded IN a thread group" sounds awkward. Did you mean "loaded BY a thread group"? > @item =library-unloaded,... > Reports that a library was unloaded by the program. This notification > has 3 fields---@var{id}, @var{target-name} and @var{host-name} with > -the same meaning as for the @code{=library-loaded} notification > +the same meaning as for the @code{=library-loaded} notification. The > +@var{thread-group} field, if present, contains the id of the thread > +group in which the library was loaded. If the field is absent, ^^^^^^ You mean "unloaded", right? > +it means the library was loaded in all present thread groups. ^^^^^^ And here. > -@samp{--all} is specified, all threads will be resumed. The > +@samp{--all} is specified, all threads (in all inferiours) will be resumed. ^^^^^^^^^^ "inferiors" (here and elsewhere in this patch) > +Identifier of the thread group. This field is always present. The > +identifier is an opaque string, and is not necessary an integer. ^^^^^^^^^ "necessarily" Also, "is an opaque string, and is not necessarily an integer" sounds strange: if it's a string, how can it be an integer? Do you mean to say that the string includes non-digit characters? > +@item executable > +The name of the executable file that corresponds to this thread group. > +The field is only present for thread groups of type @samp{process}, > +and only if there is corresponding executable file. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ "if there is a corresponding executable file". > +inferior is not associated with any executable. Such associated may > +be established with the @samp{-file-exec-and-symbols} command "Such association may be established ..." > +The inferior @var{inf} has been added to the list of inferiour. At ^^^^^^^^^ in observer.texi, too. Thanks.