From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72463-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9465 invoked by alias); 23 Apr 2010 09:30:01 -0000
Received: (qmail 9449 invoked by uid 22791); 23 Apr 2010 09:29:59 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 09:29:54 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L1B00C00OUWPP00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 23 Apr 2010 12:28:52 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.129.222]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L1B0093UP016RC0@a-mtaout22.012.net.il>; Fri, 23 Apr 2010 12:28:50 +0300 (IDT)
Date: Fri, 23 Apr 2010 09:30:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PR10179, Add support to set a breakpoint at every function in  a file
In-reply-to: <4BCE694E.9060101@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83tyr234bw.fsf@gnu.org>
References: <4BCDFEA5.9090501@redhat.com> <m3d3xtgb95.fsf@fleche.redhat.com> <4BCE694E.9060101@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00782.txt.bz2

> Date: Tue, 20 Apr 2010 22:56:14 -0400
> From: Chris Moller <cmoller@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> --- NEWS	19 Apr 2010 00:48:43 -0000	1.373
> +++ NEWS	21 Apr 2010 02:52:34 -0000
> @@ -47,6 +47,10 @@
>    single `break' command creates multiple breakpoints (e.g.,
>    breakpoints on overloaded c++ functions).
>  
> +* The `rbreak' command now accepts a filename specification as part of
> +  its argument, limiting the functions selected by the regex to those
> +  in the specified file.
> +

This part is okay.

> +	* refcard.tex (Breakpoints and Watchpoints): Added brief
> +	description of ilename-qualified rbreak.
                       ^^^^^^^
A typo.

> +@item rbreak @var{filename:regex}

This should separate filename and regex, because they are 2 distinct
arguments.

 @item rbreak @var{filename}:@var{regex}

> +If @code{rbreak} is called with a filename qualification, it limits
> +the search for functions matching the given regular expression to the
> +specified file.  This can be used, for example, to set breakponts on
> +every function in a given file:

It is a good idea to mention in the text the arguments to the
command.  Like this:

  @item rbreak @var{file}:@var{regex}

  If @code{rbreak} is called with a filename qualification, it limits
  the search for functions matching the given regular expression to the
  specified @var{file}.  This can be used, for example, to set
  breakponts on every function in a given file:

Okay with these changes.

Thanks.