Re: [PATCH 2/6] Introduce `pre_expanded sals'

Pedro Alves
2011-04-12T11:18:14Z

On Wednesday 06 April 2011 21:13:36, Tom Tromey wrote:
> >>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> This patch introduces the `pre_expanded sals'. Tom, please, if
> Sergio> you have additional comments to make regarding this
> Sergio> modification, feel free to reply to this message.
>
> This is just a way for decode_line_1 to tell the breakpoint code that
> the returned sals has multiple locations but should still create just a
> single breakpoint. We needed this because a given SystemTap probe name
> may have multiple locations.

Hmm, doesn't sound right. Conceptually, breakpoint locations are
multiple expansions of the same source location. Different source locations
are different breakpoints. E.g, bp_location doesn't have line
number or source file fields. From the user's perpective, there's
only a single "point" in the source code for all the multiple locations
for a single breakpoint.

--
Pedro Alves