Re: [RFC] - Exposing find_pc_line through Python API

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 9 May 2012 13:05:01 +0530
> From: Siva Chandra <sivachandra@google.com>
> Cc: gdb-patches@sourceware.org
> 
> 
> [1:text/plain Hide]
> 
> Eli> If I were that user, I would "feel" that the execution is at the first
> Eli> line (or maybe in the prologue) of 'func', since PC is (in my mind)
> Eli> unaffected by commands that walk the call stack.  And if you are
> Eli> talking about the value of PC saved in the frame of the caller of
> Eli> 'func', then saying that line 22 is the "actual" location is again
> Eli> confusing, because execution did not yet reach that point.
> 
> Eli> So I have hard time understanding why we need the distinction.  And
> Eli> since you say that the current Symtab_and_line.line gives the second
> Eli> alternatives, I'm confused even more.
> 
> Eli> It's possible that I'm the only confused person here, but in that
> Eli> case, at least the example should be fixed to show and explain the
> Eli> distinction more clearly and unequivocally, and also in which
> Eli> situations the "actual" value is useful.
> 
> The more I think about your comments, the more I feel that exposing
> this 'actual' argument is not a good idea.  I am now of the opinion
> that the 'notcurrent' argument to the internal function find_pc_line
> caters to a internal usage which depends on much more than just what
> the user feels.  Hence, I have modified the patch to remove the
> 'actual' argument.  The new version of the patch is attached.
> 
> 2012-05-07  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         Add a new function gdb.find_pc_line to the Python API.
>         * NEWS (Python Scripting): Add entry about the new function.
>         * python/python.c (gdbpy_find_pc_line): New function which
>         implements gdb.find_pc_line.
>         (GdbMethods): Add entry for the new function.
> 
>         doc/
>         * gdb.texinfo (Basic Python): Add description about the function
>         gdb.find_pc_line

OK for these two parts.