From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8876 invoked by alias); 9 Apr 2013 17:37:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8862 invoked by uid 89); 9 Apr 2013 17:37:15 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL,TW_DB,TW_XD autolearn=no version=3.3.1 Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Apr 2013 17:37:10 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0ML000K000TZRQ00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 09 Apr 2013 20:37:08 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ML000KT40XVDI90@a-mtaout20.012.net.il>; Tue, 09 Apr 2013 20:37:08 +0300 (IDT) Date: Tue, 09 Apr 2013 20:04:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Display configuration details in --help In-reply-to: <20836.17485.525118.795474@ruffy2.mtv.corp.google.com> To: Doug Evans Cc: tromey@redhat.com, brobecker@adacore.com, palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83txnfa9m7.fsf@gnu.org> References: <83r4jaynqq.fsf@gnu.org> <514B4AC3.1090103@redhat.com> <83zjxwy4ux.fsf@gnu.org> <20130321191051.GF5447@adacore.com> <83r4j8y1kh.fsf@gnu.org> <20130321203919.GG5447@adacore.com> <87r4j8zd0k.fsf@fleche.redhat.com> <83ehf85u7x.fsf@gnu.org> <83wqsbadfe.fsf@gnu.org> <20836.17485.525118.795474@ruffy2.mtv.corp.google.com> X-SW-Source: 2013-04/txt/msg00248.txt.bz2 > From: Doug Evans > Date: Tue, 9 Apr 2013 09:39:41 -0700 > Cc: tromey@redhat.com, brobecker@adacore.com, palves@redhat.com, gdb-patches@sourceware.org > > Hi. A few comments inline. Thanks for the review. > > - fprintf_filtered (stream, "\"."); > > + fprintf_filtered (stream, "\".\n\ > > +Type \"show configuration\" for configuration details."); > > > > if (REPORT_BUGS_TO[0]) > > { > > - fprintf_filtered (stream, > > + fprintf_filtered (stream, > > _("\nFor bug reporting instructions, please see:\n")); > > fprintf_filtered (stream, "%s.", REPORT_BUGS_TO); > > } > > } > > I have a bit of a phobia of adding more lines to gdb's initial output. > It's too long already IMO. [I realize there's -q.] > I'm not objecting per se. Just wondering how critical this is. It's not critical. But then neither is this: GNU gdb (GDB) 7.5.1 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ So I thought we should be consistent here, and offer the same for this line: This GDB was configured as "i686-pc-mingw32". I'm okay with not adding that, but can someone explain why it is different from advertising "show copying" and "show warranty"? Should we remove those two as well? > > +/* Print the details of GDB build-time configuration. */ > > +void > > +print_gdb_configuration (struct ui_file *stream) > > +{ > > + fprintf_filtered (stream, _("\ > > +This GDB was configured as follows:\n\ > > + configure --host=%s --target=%s\n\ > > +"), host_name, target_name); > > + fprintf_filtered (stream, _("\ > > + --with-auto-load-dir=%s\n\ > > + --with-auto-load-safe-path=%s\n\ > > +"), AUTO_LOAD_DIR, AUTO_LOAD_SAFE_PATH); > > +#if HAVE_LIBEXPAT > > + fprintf_filtered (stream, _("\ > > + --with-expat\n\ > > +")); > > +#else > > + fprintf_filtered (stream, _("\ > > + --without-expat\n\ > > +")); > > +#endif > > If we've already discussed this, please ignore, but ... :-) > I'd prefer one line per fprintf instead of three. Sorry, I'm not following: what 3 lines? Can you show how would you like the code be reformatted? > Also, is there something driving the choice of indenting 13 spaces in? It lines up to the right of "configure", below the first option: This GDB is configured as follows: configure --host=i686-pc-mingw32 --target=i686-pc-mingw32 --with-auto-load-dir=$debugdir:$datadir/auto-load --with-auto-load-safe-path=$debugdir:$datadir/auto-load --with-expat --with-gdb-datadir=d:/usr/share/gdb (relocatable) --with-jit-reader-dir=d:/usr/lib/gdb (relocatable) --without-libunwind-ia64 --with-lzma --with-python=d:/usr/Python26 (relocatable) --with-separate-debug-dir=d:/usr/lib/debug (relocatable) --with-system-gdbinit=d:/usr/etc/gdbinit (relocatable) --with-zlib > How about 2 or 4? > For consistency with print_gdb_help I'd go with 2. print_gdb_help displays a different information, so I see no need for consistency here. But I won't argue if others think like you do. > > fputs_unfiltered (_("\ > > --version Print version information and then exit.\n\ > > + --configuration Print details about GDB configuration and then exit.\n\ > > -w Use a window interface.\n\ > > --write Set writing into executable and core files.\n\ > > --xdb XDB compatibility mode.\n\ > > The options here are (mostly) sorted alphabetically. Except where they aren't: --args Arguments after executable-file are passed to inferior -b BAUDRATE Set serial port baud rate used for remote debugging. --batch Exit after processing options. --batch-silent As for --batch, but suppress all gdb stdout output. >>> --return-child-result GDB exit code will be the child's exit code. --cd=DIR Change current directory to DIR. --command=FILE, -x Execute GDB commands from FILE. >>> --eval-command=COMMAND, -ex Execute a single GDB command. May be used multiple times and in conjunction with --command. >>> --init-command=FILE, -ix Like -x but execute it before loading inferior. >>> --init-eval-command=COMMAND, -iex Like -ex but before loading inferior. >>> --core=COREFILE Analyze the core dump COREFILE. >>> --pid=PID Attach to running process PID. --dbx DBX compatibility mode. --directory=DIR Search for source files in DIR. --epoch Output information used by epoch emacs-GDB interface. --exec=EXECFILE Use EXECFILE as the executable. --fullname Output information used by emacs-GDB interface. --help Print this message. --interpreter=INTERP Select a specific interpreter / user interface -l TIMEOUT Set timeout in seconds for remote debugging. --nw Do not use a window interface. --nx Do not read .gdbinit file. --quiet Do not print version number on startup. --readnow Fully read symbol files on first access. --se=FILE Use FILE as symbol file and executable file. --symbols=SYMFILE Read symbols from SYMFILE. --tty=TTY Use TTY for input/output by the program being debugged. --version Print version information and then exit. -w Use a window interface. --write Set writing into executable and core files. --xdb XDB compatibility mode. Again, I'm not really wedded to the place where I inserted the new option, but please tell me near which 'c' option to put it instead ;-).