From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101797-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3787 invoked by alias); 22 May 2013 02:50:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3777 invoked by uid 89); 22 May 2013 02:50:42 -0000
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL,TW_DJ,TW_GP,TW_JG,TW_SD autolearn=no version=3.3.1
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 22 May 2013 02:50:41 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MN600E00IIPWL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 22 May 2013 05:49:44 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MN600EJ1IIWU630@a-mtaout20.012.net.il>; Wed, 22 May 2013 05:49:44 +0300 (IDT)
Date: Wed, 22 May 2013 02:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] common/filestuff.c: No sockets on DJGPP.
In-reply-to: <20130521203302.23510.45135.stgit@brno.lan>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83txlvu3ss.fsf@gnu.org>
References: <20130521203302.23510.45135.stgit@brno.lan>
X-SW-Source: 2013-05/txt/msg00803.txt.bz2

> From: Pedro Alves <palves@redhat.com>
> Date: Tue, 21 May 2013 21:33:02 +0100
> 
> Building gdb with --host=i586-pc-msdosdjgpp ends up with:
> 
>  i586-pc-msdosdjgpp-gcc -g -O2 -I../../src/gdb/config/djgpp  -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I./../intl -I../../src/gdb/gnulib/import -Ibuild-gnulib/import    -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Werror -c -o filestuff.o -MT filestuff.o -MMD -MP -MF .deps/filestuff.Tpo ../../src/gdb/common/filestuff.c
>  ../../src/gdb/common/filestuff.c:38:24: fatal error: sys/socket.h: No such file or directory
> 
> There are no sockets on djgpp.  This #ifdef's out the bits in the file
> that use sockets, depending on whether winsock or sys/socket.h is
> available.

This is fine with me, thanks.

> As alternative approach, given ser-tcp.c, ser-pipe.c, etc. are split
> into separate files, and which to use is selected by configure.ac:

Looks like overhead to me, but if others prefer this, I can go with
this as well.

Thanks.